Rewrite SDK for the v1 REST API (TypeScript + Python + Fireblocks reference)#2
Merged
Conversation
…cks reference) The previous SDK targeted the OLD codebase (GraphQL/SDL, "Instant Settlement lanes", trade-service, agent layer) and no longer matches the product. Replace it wholesale with thin, typed clients over the current non-custodial /v1 REST API: - typescript/ (@hashlock-tech/sdk) — zero-dep client on native fetch/WebSocket (Node 18+, browsers, edge): keys, assets, RFQ/quote, thread accept/propose, swaps, unsigned- tx settlement builders + broadcast, cursor pagination (page + async-iterate), webhook HMAC verify, secret/hashlock helpers, MakerFeed WS. - python/ (hashlock-sdk) — the same surface on httpx; optional [ws] extra for the maker feed; stdlib webhook verify + secret helpers. - examples/ — TS/Python quickstarts + a Fireblocks/Copper signing reference (documented, not a live integration): CONTRACT_CALL for EVM, raw-sign for TRON/Bitcoin, and the TRON approve→re-build-fund TTL note. Custody-agnostic throughout: settlement builders return UNSIGNED transactions; signing is the caller's (wallet / HSM / Fireblocks / Copper). BREAKING: full API surface change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (50)
💤 Files with no reviewable changes (22)
📝 WalkthroughWalkthroughThe repository transitions from a GraphQL TypeScript SDK to new TypeScript and Python REST SDK packages. It adds typed API clients, settlement builders, webhook verification, secret utilities, maker feeds, examples, documentation, packaging metadata, and separate TypeScript/Python CI jobs. ChangesSDK transition
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant SDK
participant HashlockMarketsAPI
participant SigningProvider
participant Blockchain
SDK->>HashlockMarketsAPI: Create RFQ and accept terms
HashlockMarketsAPI-->>SDK: Return swap and unsigned settlement build
SDK->>SigningProvider: Submit unsigned transaction
SigningProvider->>Blockchain: Sign and broadcast
Blockchain-->>SigningProvider: Return transaction hash
SigningProvider->>HashlockMarketsAPI: Relay signed transaction
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wholesale rewrite of the SDK for the current non-custodial /v1 REST API. The previous content targeted the old codebase (GraphQL/SDL, "Instant Settlement lanes", trade-service, agent layer) and no longer matches the product.
What's in it
typescript/(@hashlock-tech/sdk) — zero-dependency client on nativefetch/WebSocket(Node 18+, browsers, edge). Keys, assets, RFQ/quote, thread accept/propose, swaps, unsigned-tx settlement builders + broadcast, cursor pagination (page + async-iterate), webhook HMAC verify, secret/hashlock helpers, MakerFeed WebSocket. Typechecks clean.python/(hashlock-sdk) — the same surface onhttpx; optional[ws]extra for the maker feed; stdlib webhook verify + secret helpers. Imports + secret/hashlock verified.examples/— TS/Python quickstarts + a Fireblocks/Copper signing reference (documented, not a live integration): CONTRACT_CALL for EVM, raw-sign for TRON/Bitcoin, and the TRON approve→re-build-fund TTL note.Notes
@hashlock-tech/sdkv0.3.0.https://api-dev.hashlock.markets/v1.🤖 Generated with Claude Code
Summary by CodeRabbit