Fix offline player identity lookups#66
Merged
Merged
Conversation
remdui
marked this pull request as ready for review
July 22, 2026 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The recent asynchronous DataRegistry migration changed
PlayerReferenceResolverto read onlyfindActiveIdentityCached(...)andsnapshotActiveIdentities(). Offline players are intentionally absent from those active snapshots. Votifier therefore treated a known offline voter as unknown and returned before recording statistics or publishing the Redis reward event.Other affected features
Because the resolver is shared, the same regression affected offline sanctions, friend targeting, 2FA identifier lookup, settings/persistence operations that resolve an existing UUID, and historical username display by player ID. The central fallback fixes these callers without duplicating feature-specific lookup code.
Validation