Do not close unowned socket in Http.customRequest #12069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we create the socket, we should also close it ourselves.
If the socket doesn't belong to us, it is not safe to close it. For example, on android which enables fdsan (file descriptor sanitizer), this can cause a hard crash if the socket comes from another thread.
tobil4sk
force-pushed
the
fix/http-dont-close-unowned-socket
branch
from
09c1310 to
33d0ec0
Compare
Member
Author
|
Hm, actually, I'm not sure anymore if this fix makes sense... I think this may actually be something that should be addressed at the hxcpp level without changing the haxe api. I'll close for now and reopen if I find otherwise. |
Member
Author
|
Ok, the actual culprit for the crash was hxcpp which didn't prevent you from closing a socket handle twice, so you were able to close a handle that didn't belong to you. This still seems like it could be a sensible change, however, if it makes more sense then I'd also be happy if we add documentation to customRequest that states it automatically closes the socket for you. |
Member
|
I think this function cleaning up its own resources makes sense, so I'm happy to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the socket doesn't belong to us, it is not safe to close it.
For example, on android which enables fdsan (file descriptor sanitizer),
this can cause a hard crash if the socket comes from another threadEDIT: the actual cause for the crash was a double close.It was a bit awkward to add a test for this because there is no easy way to check whether a socket is closed, and targets have slightly different behaviours, but hopefully this should do the job.