[hl] Consider _ prefix when checking reserved keywords#12090
Merged
Simn merged 1 commit intodevelopmentfrom Mar 28, 2025
Merged
[hl] Consider _ prefix when checking reserved keywords#12090Simn merged 1 commit intodevelopmentfrom
Simn merged 1 commit intodevelopmentfrom
Conversation
Contributor
|
Seems good for me. However it seems that MSVC does not complain about the |
Member
Author
|
Well, our benchmarks will tell us if this works I suppose. |
Simn
added a commit
that referenced
this pull request
Mar 28, 2025
Simn
added a commit
that referenced
this pull request
Mar 28, 2025
* deal with local function default arguments * use on field functions too * handle during JVM preprocessing * Make analyzer thread-safe (#12083) * remove shared lattice * lose analyzer data dependency on com * how bad could it be? * make var ids atomic * optimize because stuff fails otherwise * cleanup * how far can we take this? * Revert "don't generate constructor on abstract classes" This reverts commit d38ba0e. * consider _ prefix when checking reserved keywords (#12090) closes #12089 * change parallel API * [python] Mark threads as daemon threads. (#12096) Otherwise background threads keep the program alive, which is not consistent with other targets. * Revert "Make some filters thread-safe (#12087)" This reverts commit 7ea0972. # Conflicts: # src/filters/filters.ml --------- Co-authored-by: Zeta <53486764+Apprentice-Alchemist@users.noreply.github.com>
Member
Author
|
The benchmarks show values for HL/C now. Terrible values, but values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #12089