-
-
Notifications
You must be signed in to change notification settings - Fork 690
Revert things #12097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert things #12097
Conversation
|
I'm having a hard time understanding how what I've done so far could cause compiler hangs. While there's an amount of parallelism, there's almost no actual synchronization that could deadlock. Outside of genjvm, the only mutex that was added is around a mkdir operation. Up until now, the only problems were caused by unsynchronized access to shared data, which usually causes some explicit exception. A stack overflow could in theory cause a hang due to tail-call elimination, but I don't see how we would cause one. The changes in 47c3bf7 could of course be related to something like this, though I'd expect there to be problems even outside of parallel-world if that was the case. I haven't seen the setup timeout in the server tests since 7b20817, but there was a hang in the misc test and a few seemingly random failures in some server tests. For now, the best I can do is observe. |
|
Logging some failures:
A striking commonality between these three is that they all compile to neko. Edit: Unfortunately, "Setup timeout" has returned too. Edit: Development hangs on |
|
One interesting thing about both 2538 and 4742 is that the tests raise an |
Simn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some doubts that this is how real parallel programmers handle such things, but it makes some sense to me...
|
Looks like that did the trick! I can't say I fully understand the behavior here, but the conclusion is to not have unhandled exceptions in your task runners. |
Investigating CI hangs...