Skip to content

msvc: fix XP subsystem flags, add x64 XP correction#196

Closed
ruby0x1 wants to merge 1 commit intoHaxeFoundation:masterfrom
ruby0x1:xp-fixes
Closed

msvc: fix XP subsystem flags, add x64 XP correction#196
ruby0x1 wants to merge 1 commit intoHaxeFoundation:masterfrom
ruby0x1:xp-fixes

Conversation

@ruby0x1
Copy link
Contributor

@ruby0x1 ruby0x1 commented Mar 25, 2015

This commit makes three important fixes for WinXP support;

  1. rename CONSOLE_VER -> SUBSYSTEM_VER (it's not specific to
    console subsystem)
  2. -subsystem ${ver} value is required for both types for XP
    compat
  3. Adds the x64 variation for windows XP x64 builds (5.02, x86 is 5.01)

MSDN has all the details to verify,
I tested a plain 32 bit build (built with vs2013 on Windows 8.1),
Running on XP 32 bit: It fails to run with "not a valid win32
application".

Adding the correct subsystem flags makes it work as expected under the
same setup.
More info here if needed:
https://msdn.microsoft.com/en-us/library/fcc1zstk.aspx

This commit makes three important fixes for WinXP support;

1) rename `CONSOLE_VER` -> `SUBSYSTEM_VER` (it's not specific to
console subsystem)
1) `-subsystem` ${ver} value is **required** for both types for XP
compat
2) Adds the x64 variation for windows XP x64 builds (5.02, x86 is 5.01)

MSDN has all the details to verify,
I tested a plain 32 bit build (built with vs2013 on Windows 8.1),
Running on XP 32 bit: It fails to run with "not a valid win32
application".

Adding the correct subsystem flags makes it work as expected under the
same setup.
More info here if needed:
https://msdn.microsoft.com/en-us/library/fcc1zstk.aspx
@hughsando
Copy link
Member

I have merged this in, and allowed XP_COMPAT for x64. Now, I default to xp compat for 32 bit, but you need to explicitly put it on for 64 bit. Not sure how many people are making 64 bit exes for XP, but there is at least an option now. I generated the files and they ran on win 8.1. Have not tested them on a winxp box though.
Thanks.

@hughsando hughsando closed this Mar 30, 2015
@ruby0x1
Copy link
Contributor Author

ruby0x1 commented Mar 30, 2015

Sounds fine (the 64bit fix was just a side effect since the value differs)

@ruby0x1 ruby0x1 deleted the xp-fixes branch March 30, 2015 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants