msvc: fix XP subsystem flags, add x64 XP correction#196
Closed
ruby0x1 wants to merge 1 commit intoHaxeFoundation:masterfrom
ruby0x1:xp-fixes
Closed
msvc: fix XP subsystem flags, add x64 XP correction#196ruby0x1 wants to merge 1 commit intoHaxeFoundation:masterfrom ruby0x1:xp-fixes
ruby0x1 wants to merge 1 commit intoHaxeFoundation:masterfrom
ruby0x1:xp-fixes
Conversation
This commit makes three important fixes for WinXP support;
1) rename `CONSOLE_VER` -> `SUBSYSTEM_VER` (it's not specific to
console subsystem)
1) `-subsystem` ${ver} value is **required** for both types for XP
compat
2) Adds the x64 variation for windows XP x64 builds (5.02, x86 is 5.01)
MSDN has all the details to verify,
I tested a plain 32 bit build (built with vs2013 on Windows 8.1),
Running on XP 32 bit: It fails to run with "not a valid win32
application".
Adding the correct subsystem flags makes it work as expected under the
same setup.
More info here if needed:
https://msdn.microsoft.com/en-us/library/fcc1zstk.aspx
Member
|
I have merged this in, and allowed XP_COMPAT for x64. Now, I default to xp compat for 32 bit, but you need to explicitly put it on for 64 bit. Not sure how many people are making 64 bit exes for XP, but there is at least an option now. I generated the files and they ran on win 8.1. Have not tested them on a winxp box though. |
Contributor
Author
|
Sounds fine (the 64bit fix was just a side effect since the value differs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes three important fixes for WinXP support;
CONSOLE_VER->SUBSYSTEM_VER(it's not specific toconsole subsystem)
-subsystem${ver} value is required for both types for XPcompat
MSDN has all the details to verify,
I tested a plain 32 bit build (built with vs2013 on Windows 8.1),
Running on XP 32 bit: It fails to run with "not a valid win32
application".
Adding the correct subsystem flags makes it work as expected under the
same setup.
More info here if needed:
https://msdn.microsoft.com/en-us/library/fcc1zstk.aspx