fix: increase success toast timeout to 5 seconds - #545
Conversation
|
@AbimbolaDann is attempting to deploy a commit to the David Dada's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@AbimbolaDann Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
sshdopey
left a comment
There was a problem hiding this comment.
Thanks for tackling this! Increasing the success toast timeout to 5 seconds (with a 7-second minimum for success toasts) directly addresses the issue where confirmations were too easy to miss. I appreciate the named constants for easier tuning and that you kept other toast types unchanged. The diff is focused and clearly related to the linked bug. Nice work! ❤️
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
sshdopey
left a comment
There was a problem hiding this comment.
Thanks for tackling this! I can see you put real effort into making the success toast stay visible longer, which directly addresses the reported issue. The change to enforce a minimum duration for success toasts is a thoughtful approach, and I appreciate that you kept other toast types unaffected. The code compiles and the logic is clear. Great work on this fix — it's a solid contribution! ❤️
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
sshdopey
left a comment
There was a problem hiding this comment.
Great work on this fix! Increasing the success toast timeout to 5 seconds (with a minimum of 7 seconds for success toasts) directly addresses the issue of users missing important confirmations. The use of named constants makes the durations clearer and easier to tune. I appreciate that you kept other toast types unchanged and verified the behavior. Thanks for contributing! ❤️
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
sshdopey
left a comment
There was a problem hiding this comment.
Hey AbimbolaDann, thanks for tackling this! 🎉 Your change to bump the success toast timeout to 5 seconds (with a 10-second minimum for success toasts) directly addresses the issue where users couldn't read confirmations in time. I love that you added named constants for clarity and kept other toast types unaffected. The diff is clean and the logic is sound. Great work on the tests and manual verification too! Keep it up! 💪
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
sshdopey
left a comment
There was a problem hiding this comment.
Hey AbimbolaDann! Thanks for tackling this issue. I can see you've put real effort into extending the success toast timeout to 5 seconds (and even more for success toasts), which directly addresses the problem. The code changes are substantial and clearly related to the linked issue. I noticed a few minor things like a typo in a comment and some formatting changes, but nothing that blocks merging. Great work on keeping other toast types unaffected and adding a named constant for easier tuning. Keep it up! ❤️
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
Overview
The success toast notification currently auto-dismisses after 2 seconds, making it easy for users to miss important investment confirmation details. This PR increases the success toast timeout to 5 seconds so critical confirmations remain readable, while preserving the behavior of other toast types.
Related Issue
Closes the reported bug: Success toast notification disappears before user can read it — 2s timeout too short
Changes
🔔 Success Toast Timeout
src/components/Toast.tsxVerification Results
Closes #428