fix(ui): close menu dropdowns on outside click and Esc, add an X to Recent - #566
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
angela-helios
added a commit
that referenced
this pull request
Aug 19, 2026
Main brought Bulk Export (#538), the dashboard job cards (#565), and the menu close behaviors (#566). The vocabulary work carries over both export pages, which predate #543: canonical title/button classes, the job-status chips move onto the .tag status-pill family (main's new .chip block collided with the facet-chip component — exactly the duplicate this branch exists to kill), the typegrid joins the pages layer, the job-card additions join the components layer, and both export routes join the shared guard list. Also makes the design-system guard read app.css and the shipped scripts over HTTP from the server under test instead of the source tree: the CI runner drives a packaged binary with no checkout alongside it (the ENOENT on every merge-ref run), and in HFS_E2E_BASE_URL mode the running server is the only truth worth checking anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Recent-searches popup on Search / Saved Queries only closed by re-clicking its toggle (or by picking an entry). Manual testing flagged that it should also close on an outside click and from an explicit control.
What changed
addbox.js(UI: Add-tenant panel can't be cancelled — no close (×) control, no Esc, no click-outside #545) now covers<details class="menu">dropdowns as well asdetails.addbox: an outside click closes any open panel, Esc closes them, and[data-addbox-close]closes its own panel. That picks up the Recent popup and the sidebar's tenant and FHIR-version selectors, which had the same gap — all the chrome dropdowns now behave alike.data-addbox-close,aria-label/titlefrom the existingui-closekey, so no new i18n strings).Tests
data-addbox-close).cargo test -p helios-ui --lib: 67 passed.