POC: native SQL-on-FHIR query notebook (#650) - #768
Draft
dougc95 wants to merge 2 commits into
Draft
Conversation
Runnable thin-slice of the #650 recommendation: a self-contained page at /ui/sql/notebook (one handler + inline HTML/CSS/JS, no template, no CDN, no new deps) that runs a ViewDefinition against same-origin $sql-run and renders the result as a table plus an inline-SVG group-by chart — the "write a ViewDefinition, run it, chart the result without leaving the server" loop, native in the existing Rust/HTMX UI. cargo check -p helios-ui: clean. See poc/native-notebook/README.md for run steps and the deliberate POC shortcuts (client-side aggregation, no identity/persistence). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PTFfaGwHDggEbrFtfejJtE
The exact /ui/sql/notebook page (HTML from the committed handler) running a query and rendering the result table + inline-SVG group-by chart. $sql-run was stubbed to 24 sample Patients for the screenshot; live it calls the server.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
dougc95
added a commit
that referenced
this pull request
Aug 28, 2026
…vs proposal (#650) Adds a "Proof of concept" subsection to §5 mapping each option to its built demonstrator (PRs #768-#771) with what each verified, and relabels the now-shown feasibility as [demonstrated] while keeping the product decision, correct Stage 2, Stage 3, and the open questions as [proposal].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof-of-concept for the recommended approach in the #650 evaluation: close the loop inside HFS — no new runtime, no CDN, no external assets.
What it is
A self-contained page at
/ui/sql/notebookincrates/ui: edit a ViewDefinition, run it against the same-origin$sql-runendpoint, and get a result table + an inline-SVG group-by chart. One handler returning inline HTML/CSS/JS — no Askama template, no npm, no vendored assets — so the no-CDN Playwright guard and the rust-embed story are untouched. The page talks only to$sql-run, inheriting the server's auth / tenant / row limits ("data, not credentials").Verified
cargo check -p helios-ui— clean.$sql-runwas stubbed to sample Patients for the screenshot; live it calls the server.)Run
See
poc/native-notebook/README.mdfor the deliberate POC shortcuts — client-side aggregation (must move server-side for large views), no per-user identity, no saved-notebook persistence — i.e. the Stage-2/3 open questions from the evaluation.POC branch demonstrating the primary #650 direction. Relates to #650.