fix: retry transient file locks in release test cleanup#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.1.2attempt) failed only in cleanup:test-portable.ps1hitAccess to the path '...\Microsoft.Terminal.Control.dll' is deniedwhile removing its temp extract root, after every functional gate had passed. A just-terminated winTerm process (or an antivirus scan of freshly written binaries) can keep a mapped file locked for a short moment.Remove-DirectoryWithRetry(up to 5 attempts with 250/500/750/1000 ms backoff, early exit when the directory is already gone, rethrow on final failure) toscripts/winterm/test-portable.ps1andscripts/winterm/test-installer.ps1, and routes their recursive temp-directory cleanup through it.verify-release-layout.ps1never launches the payload and has never flaked, so it is left as is. No product code, schemas, or workflows are touched.Validation
scripts/winterm/test.ps1 -Suite Smoke -Configuration Release -Platform x64— passed.git diff --check— clean.winterm-validation.yml,winterm-full-build.yml); no local native toolchain is available.Notes
%TEMP%) is unchanged and still runs before any removal.