Pin rxjs to 7.8.2 in backend (fixes nestjs bump #109)#140
Merged
Conversation
keysersoft
force-pushed
the
keysersoft/pin-rxjs
branch
from
b4ddfdc to
4e9afff
Compare
Backend declared rxjs as ^7.8.1, but several @nestjs/cli transitive deps (@angular-devkit/*) pin rxjs to exact 7.8.1, while the rest of the @nestjs ecosystem resolves to 7.8.2. With certain bumps (e.g. the @nestjs/cli 11.0.21 group in PR #109), npm decides to install a second rxjs at packages/backend/node_modules/rxjs, breaking typecheck with 'Observable from two different rxjs' errors because the backend ends up with two rxjs instances at different paths. Pinning rxjs in backend to the exact 7.8.2 used by the @nestjs/common, @nestjs/core, etc. ecosystem forces npm to dedupe to a single root copy. The @Angular-devkit nested 7.8.1 copies remain but are isolated to nest-cli tooling and never reach the backend's compiled code.
keysersoft
force-pushed
the
keysersoft/pin-rxjs
branch
from
4e9afff to
a8a3c2f
Compare
This was referenced May 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rxjsinpackages/backend/package.jsonfrom^7.8.1to exactly7.8.2.Root cause
Backend declared
rxjs: "^7.8.1", but:@angular-devkit/*(transitive of@nestjs/cli) pinsrxjs: "7.8.1"exactly.@nestjsecosystem (@nestjs/common,core,terminus,mcp-nest,nestjs-pino) resolvesrxjsto 7.8.2.When the @nestjs/cli bump in #109 lands, npm gets confused and installs a second rxjs at
packages/backend/node_modules/rxjs, leaving the root one at 7.8.2. Two rxjs instances → twoObservable<any>types → typecheck breaks on the OAuth interceptor with "Observable from two different rxjs" errors.Fix
Pinning backend to
7.8.2(the version the rest of the ecosystem already wants) makes npm hoist a single root copy. The@angular-devkitnested 7.8.1 copies remain but are scoped to nest-cli tooling and never reach the backend runtime.Test plan
npm installafter pin → only onenode_modules/rxjs, no nested copy inpackages/backend/npx tsc --noEmit -p packages/backend/tsconfig.json→ exit 0 (was failing on PR Bump the nestjs group across 1 directory with 2 updates #109 branch)