Force rxjs to 7.8.1 across workspace (unblocks #109)#142
Merged
Conversation
Follow-up to the previous rxjs pin (7.8.2): with the @nestjs/cli 11.0.21 bump in PR #109, npm hoists rxjs 7.8.1 at the root because the bumped @angular-devkit/* (transitive of nest-cli) hard-pins rxjs to 7.8.1. Backend pinned to 7.8.2 then ends up with a nested rxjs at packages/backend/node_modules/rxjs, reproducing the duplicate-Observable typecheck error. Pinning backend to 7.8.1 and adding a root override 'rxjs: 7.8.1' aligns backend with the angular-devkit-driven root resolution. The remaining @nestjs ecosystem also accepts 7.8.1 (their range is ^7.8.0 or wider). After this change npm hoists a single rxjs at root; nested copies in @angular-devkit/concurrently/@nestjs/schematics remain but are isolated to those tools' internals and never collide with backend types.
Regenerating the lockfile to apply the rxjs override also bumped eslint-plugin-react-hooks transitively from 7.0.1 to 7.1.1 (via eslint-config-next), which introduced a new 'use-before-define' rule that flags two pre-existing patterns in the frontend (connectors/store/page.tsx and settings/license/page.tsx). Pinning the plugin to 7.0.1 keeps the lockfile aligned with main's behaviour; the new rule can be addressed in a separate PR.
This was referenced May 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #140. With the
@nestjs/cli 11.0.21bump in #109, the bumped@angular-devkit/*(transitive of nest-cli) hard-pinsrxjsto 7.8.1 at the root. With backend pinned to 7.8.2, npm installs a second rxjs atpackages/backend/node_modules/rxjs, reproducing the duplicate-Observable typecheck error.Fix
rxjs: 7.8.1(matching what angular-devkit drives at root)."overrides": { "rxjs": "7.8.1" }to keep all consumers aligned regardless of future bumps.After this, only
node_modules/rxjsis hoisted; nested copies remain in@angular-devkit/*,concurrently,@nestjs/schematicsbut are isolated to those tools' internals.Test plan
tsc --noEmit -p packages/backend/tsconfig.json→ exit 0 on this branchpackages/backend/node_modules/rxjs/after install