Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many random GOG games listed as "not installable" #3636

Closed
twiztedtbone opened this issue Mar 17, 2024 · 12 comments · Fixed by #3711
Closed

many random GOG games listed as "not installable" #3636

twiztedtbone opened this issue Mar 17, 2024 · 12 comments · Fixed by #3711
Labels
bug:unconfirmed Someone works on identifying the issue GOG

Comments

@twiztedtbone
Copy link

Describe the bug

GOG account (and only that, no Epic/Amazon) successfully linked, have two games currently installed that I play frequently. Upon opening Heroic, on the Library tab, many games are listed as not installable with the message: "This game doesn't appear to be installable. Check downloadable content on https://gog.com/account". Checking my GOG account shows the games are all perfectly available for download.

I have played many of these games previously via Lutris/Bottles, so I know they're both a) available and b) work on Linux.

Add logs

(18:04:49) INFO:    [Legendary]:        Legendary location: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary
(18:04:49) INFO:    [Gog]:              GOGDL location: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
(18:04:49) INFO:    [Connection]:       Connectivity: check-online
(18:04:49) INFO:    [Connection]:       Pinging external endpoints
(18:04:49) INFO:    [Gog]:              Checking for existing gog manifests
(18:04:49) INFO:    [Backend]:          DRM module staus {
  "oimompecagnajdejgnnjijobebaeigek": {
    "name": "Widevine Content Decryption Module",
    "status": "new",
    "version": "4.10.2710.0"
  }
}
(18:04:49) WARNING: [Backend]:          Protocol already registered.
(18:04:49) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=/home/username/.config/heroic/legendaryConfig/legendary /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary --version
(18:04:49) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/username/.config/heroic/gogdlConfig /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/username/.config/heroic/gog_store/auth.json --version
(18:04:49) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=/home/username/.config/heroic/nile_config /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/nile --version
(18:04:49) INFO:    [Connection]:       Connectivity: online
(18:04:49) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/username/.config/heroic/gogdlConfig /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/username/.config/heroic/gog_store/auth.json auth
(18:04:49) INFO:    [Backend]:          User Not Found, removing it from Store
(18:04:49) INFO:    [Gog]:              Checking if login is valid
(18:04:49) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/username/.config/heroic/gogdlConfig /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/username/.config/heroic/gog_store/auth.json auth
(18:04:49) INFO:    [Backend]:          
System Information:
CPU: 16x 11th Gen Intel(R) Core(TM) i7-11700F @ 2.50GHz
Memory: 33.52 GB (used: 9.01 GB)
GPUs:
  GPU 0:
    Name: NVIDIA Corporation GA102 [GeForce RTX 3080 Ti]
    IDs: D=2208 V=10de SD=3955 SV=3842
    Driver: nvidia
OS: Arch Linux 6.8.1-arch1-1 (linux)

The current system is not a Steam Deck
We are not running inside a Flatpak container

Software Versions:
  Heroic: 2.13.0 Dorry & Broggy
  Legendary: 0.20.34 Direct Intervention
  gogdl: 1.0.0
  Nile: 1.0.1 Jonathan Joestar

(18:04:49) INFO:    [Frontend]:         Refreshing undefined Library
(18:04:49) WARNING: [Backend]:          refresh not implemented on Sideload Library Manager
(18:04:49) INFO:    [Legendary]:        Refreshing library...
(18:04:49) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/username/.config/heroic/gogdlConfig /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/username/.config/heroic/gog_store/auth.json auth
(18:04:49) INFO:    [Backend]:          Frontend Ready
(18:04:49) INFO:    [Gog]:              Getting GOG library
(18:04:49) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/username/.config/heroic/gogdlConfig /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/username/.config/heroic/gog_store/auth.json auth
(18:04:49) INFO:    [Backend]:          Checking for new Heroic Updates
(18:04:49) INFO:    [Backend]:          AreWeAntiCheatYet data downloaded
(18:04:49) INFO:    [Backend]:          Checking for current version changelog
(18:04:50) INFO:    [Gog]:              Saved username to config file
(18:04:51) INFO:    [Winetricks]:       Downloading Winetricks
(18:04:54) INFO:    [WineDownloader]:   Updating wine versions info
(18:04:54) INFO:    [WineDownloader]:   Fetching upstream information...
(18:04:54) INFO:    [Backend]:          Starting the Download Queue
(18:04:58) INFO:    [WineDownloader]:   wine versions updated

Steps to reproduce

  1. Open Heroic, navigate to Library tab
    1.5. See that many games are uninstallable
  2. Click on an uninstallable game
    2.5. See the aforementioned message in full

Expected behavior

For the uninstallable games to be installable

Screenshots

heroic_gog_issue_1
heroic_gog_issue_2

Heroic Version

Latest Stable

System Information

  • Arch (up to date)
    • Heroic installed via AUR (heroic-games-launcher-bin)
    • GNOME/X11
  • 11700F
  • 3080Ti
  • 32G RAM

Additional information

No response

@twiztedtbone twiztedtbone added the bug:unconfirmed Someone works on identifying the issue label Mar 17, 2024
@Lariaa
Copy link
Collaborator

Lariaa commented Mar 18, 2024

Have a look if there is a second entry for those games.
We right now don't collapse demos, dlcs, packages and bonus material into one entry and if you are looking at let's say a soundtrack entry, the "not installable" label is correct.

@Periyte
Copy link
Contributor

Periyte commented Mar 18, 2024

It happens randomly in my library too, with games from GOG (not goodies or else).

@twiztedtbone
Copy link
Author

Have a look if there is a second entry for those games. We right now don't collapse demos, dlcs, packages and bonus material into one entry and if you are looking at let's say a soundtrack entry, the "not installable" label is correct.

I don't believe this to be the case, certainly not with over 33% (I'm lowballing in lieu of actually counting, but it's a lot, approaching half) of my GOG games.

Here is, for example, Plague Tale's entry on gog.com; no second entry, no DLC, no soundtrack, etc.:
heroic_gog_issue_3

@arielj
Copy link
Collaborator

arielj commented Mar 18, 2024

This seems to happen when, for some reason, heroic can't fetch the content information from GOG's API https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/pull/2759/files#diff-14645ea20292edb3fd5d19b27f1551d877765ccf5bd6f49e252aa657a564696eR644

then installable is undefined or false and it ends up showing that message

I'm not sure why it's failing to connect though, we probably should add some logs when that happens. here for example https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/pull/2950/files#diff-14645ea20292edb3fd5d19b27f1551d877765ccf5bd6f49e252aa657a564696eR200

any thoughts on this @imLinguin ?

@imLinguin
Copy link
Member

I guess this issue should be reduced by axios connection re-use. However we can also consider completely removing this check and check for this while getting install info

@hardpenguin
Copy link

Also affected by this, closing the app and starting it up again only caused different group of games to be affected than the first time.

@cortu01
Copy link

cortu01 commented Apr 13, 2024

Also affected by this, closing the app and starting it up again only caused different group of games to be affected than the first time.

Same issue here. I would add that I see the same few games having installation enabled/disabled each time I reload the app. Vast majority of games remains uninstallable. Alternate software does not exhibit this problem.

@SkalCore
Copy link

same behaviour here,,,it is a littlebit annoying

@arielj
Copy link
Collaborator

arielj commented Apr 15, 2024

can anyone try the build from this PR #3700 ?

@Periyte
Copy link
Contributor

Periyte commented Apr 16, 2024

can anyone try the build from this PR #3700 ?

I tested it with a clean install on Windows and I didn't notice any game marked as "Not Installable" this time. I wonder if it didn't improve library fetching process speed too.

@shakeyourbunny
Copy link

shakeyourbunny commented Apr 21, 2024

can anyone try the build from this PR #3700 ?

I downloaded the AppImage artifact from https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/actions/runs/8696093997, as I have the same problem and wiped the configuration.

Currently I have about 2779 games in my library.

image

Heroic Games Launcher, after fresh start, it says that I have 2070 games and most of then are still blocked.
image

There is something really broken in the API with the Python fork of GOGDL, why not just using lgogdownloader which has had never problems getting and managing GOG games? It seems that GOGDL does not really can throttle its API calls properly for getting the data reliably.

Main cause is that the log file is full of

(11:52:34) ERROR:   [Gog]:              Failed to fetch product data for 1207666513, retrying
(11:52:34) ERROR:   [Gog]:              Failed to fetch product data for 1430742927, retrying
(11:52:34) ERROR:   [Gog]:              Failed to fetch product data for 1207666513, retrying
(11:52:34) ERROR:   [Gog]:              Failed to fetch product data for 1207666513, retrying
(11:52:34) ERROR:   [Gog]:              Failed to fetch product data for 1430742927, retrying
(11:52:34) ERROR:   [Gog]:              Failed to fetch product data for 1430742927, retrying
(11:52:35) ERROR:   [Gog]:              Failed to fetch product data for 1207667173, retrying
(11:52:35) ERROR:   [Gog]:              Failed to fetch product data for 1207667173, retrying
(11:52:35) ERROR:   [Gog]:              Failed to fetch product data for 1207667173, retrying

Log files for Heroic Launcher & gogdl:
https://gist.github.com/shakeyourbunny/5ef133b8c95bca34c75fe568217fb5ba

@shakeyourbunny
Copy link

Clicking once on the refresh symbol seems to load some more games, it is 2770, my guess is that gogdl fails to load the last library page.
image

Clicking a third time (and waiting until it finishes) seems not to add the missing 9 games. Seems to be another bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:unconfirmed Someone works on identifying the issue GOG
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants