feat: add WithGuild to pin the default guild - #13
Merged
Conversation
Guild-scoped ops fell back to Guilds().Sole, which errors as soon as the bot is in more than one server — command registration then fails outright with no way to say which server was meant. WithGuild pins it without a network call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guilds().Soleerrors as soon as the bot is in more than one server, and every guild-scoped op that takes""goes through it — so a bot invited to a second guild loses slash-command registration with no way to say which server was meant.WithGuild(id)pins the default guild on the client. It short-circuitsresolveGuildbefore the sole-guild lookup, so it costs no network call and does not touch the memoizedSolepath. An explicit per-call guild id still wins.Tests: configured guild beats a two-server
List(which still fails without it), andWithGuildthreads throughNew.