feat(messages): Get one message by id, and surface embeds - #18
Merged
Conversation
Read only reaches the tail of a channel, so a message named by anything other than recency — the one a reply points at — was unreachable. And Message dropped embeds entirely: a webhook or a bot puts its whole report in an embed, so a reader that only sees Content sees an empty message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps that show up together when reading a message someone replied to.
Messages().Get(ctx, channelID, messageID)—GET /channels/{ch}/messages/{id}.Readonly walks back from the channel's tail, so a message named by id (a reply's target, hours old) had no path.Message.Embeds []Embed(Title,Description,URL,Image,Thumbnail,Fields). A bot or webhook posts with an emptycontentand everything in an embed; decoding without them made those messages read as blank.Image/Thumbnailare pointers so "no picture" is distinguishable from "a picture at the empty URL". Additive only — no existing field or signature changed.