fs: ll_mkdir/write -> provider.mkdir/write#1362
Merged
KernelDeimos merged 2 commits intoHeyPuter:mainfrom Jul 29, 2025
Merged
Conversation
36fd1fe to
0d021cc
Compare
0d021cc to
cf3292f
Compare
Contributor
Author
|
hey @KernelDeimos |
| if ( ! values.overwrite && ! values.dedupe_name ) { | ||
| throw APIError.create('item_with_same_name_exists', null, { | ||
| entry_name: target_name, | ||
| entry_name: await dest.get('name'), |
Contributor
There was a problem hiding this comment.
Did target_name have a different value here?
Contributor
Author
There was a problem hiding this comment.
yeah, they are different is this request:
{
"source": "//admin/api_test/move_cart_3/a/a_file.txt",
"destination": "//admin/api_test/move_cart_3/b"
}
dest.get('name'): b
target_name: a_file.txt
and we are expecting b in the error:
puter/tools/api-tester/tests/move_cart.js
Lines 88 to 92 in 5b46f0b
It's produced by:
node ./tools/api-tester/apitest.js --config=./tools/api-tester/config.yml --unit --suite=move_cart
Contributor
There was a problem hiding this comment.
Does /admin/api_test/move_cart_3/b already exist in this case?
Contributor
Author
There was a problem hiding this comment.
yeah, exists as a normal file:
immutable =
0
is_dir =
0
is_public =
null
is_shortcut =
0
is_symlink =
0
It's created here:
puter/tools/api-tester/tests/move_cart.js
Lines 28 to 30 in 5b46f0b
cf3292f to
f120fa5
Compare
f120fa5 to
55ebcf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a task related to #1354
I moved the mkdir/write logic from
ll_mkdir.js/ll_write.jstoPuterFSProvider.jswith minimal changes.Test
This PR also passed all the apitest since it's based on #1376