fix failed tests in apitest (move_cart and stat)#1376
fix failed tests in apitest (move_cart and stat)#1376KernelDeimos merged 2 commits intoHeyPuter:mainfrom
move_cart and stat)#1376Conversation
|
This PR is ready for review and merge, as long as the pending reviews are resolved. |
KernelDeimos
left a comment
There was a problem hiding this comment.
Looks good, I'll merge this as soon as I understand why the fix for stat works - it doesn't look like it should change anything
| if (return_subdomains) await subject.fetchSubdomains(user) | ||
| if (return_permissions) await subject.fetchShares(); | ||
| if (return_permissions) { | ||
| subject.entry.permissions = []; |
There was a problem hiding this comment.
How does this fix the test? It looks like FSNodeContext.fetchShares does not try to access or create any property called permissions on the raw entry.
|
All apitests passed, this PR is ready for review/merge |
|
Thanks, I'm merging this now. I think apitest is a great place to put end-to-end tests for invoking LLMs through Puter's API. We can actually test Puter AI at two different layers:
Before we can do either of these I created a prerequisite task for formalizing the input/output formats for Puter AI. Can you work on this next? |
This is a continuation of PR #1369
Originally, there were 5 failed test in apitest:
This PR fixed all the failed tests:
and made some update to apitest:
--suite=<suite-name>argument