Skip to content

fs: adapt to different mkdir api, block write to root dir, add tests#1369

Merged
KernelDeimos merged 3 commits intoHeyPuter:mainfrom
XiaochenCui:fs/mkdir-1367
Jul 22, 2025
Merged

fs: adapt to different mkdir api, block write to root dir, add tests#1369
KernelDeimos merged 3 commits intoHeyPuter:mainfrom
XiaochenCui:fs/mkdir-1367

Conversation

@XiaochenCui
Copy link
Copy Markdown
Contributor

test:

> node ./tools/api-tester/apitest.js --config=./tools/api-tester/config.yml --unit

=== Test Results ===
┌─────────────────────────────────┬────────┬────────┬───────┐
│ (index)                         │ passed │ failed │ total │
├─────────────────────────────────┼────────┼────────┼───────┤
│ Cartesian Test for /write       │ 24     │ 0      │ 24    │
│ Cartesian Test for /move        │ 44     │ 4      │ 48    │
│ Cartesian Test for /copy        │ 144    │ 0      │ 144   │
│ write and read                  │ 6      │ 0      │ 6     │
│ move                            │ 4      │ 0      │ 4     │
│ stat                            │ 133    │ 1      │ 134   │
│ readdir                         │ 115    │ 0      │ 115   │
│ mkdir                           │ 22     │ 0      │ 22    │
│ batch                           │ 4      │ 0      │ 4     │
│ delete                          │ 7      │ 0      │ 7     │
│ single write for trace and span │ 0      │ 0      │ 0     │
└─────────────────────────────────┴────────┴────────┴───────┘

All mkdir tests passed. The failed tests are unrelated to this PR.

@XiaochenCui
Copy link
Copy Markdown
Contributor Author

@KernelDeimos
this PR is ready for review & merge

Comment thread src/backend/src/filesystem/hl_operations/hl_mkdir.js Outdated
Comment thread src/backend/src/filesystem/hl_operations/hl_mkdir.js Outdated
@KernelDeimos KernelDeimos merged commit fee100d into HeyPuter:main Jul 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fs: failed to mkdir when parent arg is missing

2 participants