GUI: fix dev-server port-retry crash under Express 5 - #3482
Merged
Conversation
Express 5's app.listen wraps the listen callback in once() and also invokes it on 'error', with the error as the first argument — at which point server.address() is null, so the startup log threw a TypeError and killed the process before the EADDRINUSE handler could try the next port. Bail out of the callback when it receives an error and let the 'error' listener own the retry. Verified: with 4000 occupied the server now logs the retry and comes up on 4001; with the port free it binds 4000 as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Express 5's app.listen wraps the listen callback in once() and also invokes it on 'error', with the error as the first argument — at which point server.address() is null, so the startup log threw a TypeError and killed the process before the EADDRINUSE handler could try the next port. Bail out of the callback when it receives an error and let the 'error' listener own the retry.
Verified: with 4000 occupied the server now logs the retry and comes up on 4001; with the port free it binds 4000 as before.