Skip to content

Refactor: OAuth 응답 및 LLM 메타데이터 정리 - #23

Merged
Heyaaz merged 2 commits into
mainfrom
refactor/backend-oauth-metadata-cleanup
May 24, 2026
Merged

Refactor: OAuth 응답 및 LLM 메타데이터 정리#23
Heyaaz merged 2 commits into
mainfrom
refactor/backend-oauth-metadata-cleanup

Conversation

@Heyaaz

@Heyaaz Heyaaz commented May 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • 백엔드 OAuth/일정 응답 매퍼 정리

Changes

  • Google/Kakao OAuth 사용자 조회·생성 로직 공통화
  • OAuth 인증 응답 payload 생성 로직 공통화
  • 일정 LLM 메타데이터 unchecked cast suppression 제거

Verification

  • Not run
  • Build
  • Test
    • ./gradlew test
    • ./gradlew test --tests com.tripsync.AuthContractTests
    • ./gradlew test --tests com.tripsync.application.schedule.ScheduleResponseMapperTest --tests com.tripsync.AuthContractTests
    • ./gradlew check
  • Manual

Notes

@Heyaaz Heyaaz left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nogada PR Review

Verdict: Approved ✅

Blocking Issues

  • 없음.

Notes

  • OAuth2UserService의 Google/Kakao 사용자 조회·생성 및 인증 응답 생성 로직이 공통 함수로 분리됐고, 기존 응답 필드(token, userId, nickname, email, authProvider)는 유지됩니다.
  • ScheduleResponseMapper의 LLM 메타데이터 캐스팅이 Map<*, *> 기반으로 정리되어 unchecked cast 경고 제거 목적에 맞습니다.
  • 테스트 종료 시 Testcontainers/Hikari/PostgreSQL shutdown warning이 출력됐지만, Gradle은 성공 종료했고 XML 결과도 실패/에러 0건이라 비차단으로 봤습니다.

Verification

  • git diff --check origin/main...pr-23
  • ./gradlew clean test --no-daemon --no-build-cache
  • ✅ Test XML: 12 files / 65 tests / 0 failures / 0 errors / 0 skipped

[Heyaaz의 Nogada]

@Heyaaz
Heyaaz merged commit 71ea48d into main May 24, 2026
1 check passed
@Heyaaz
Heyaaz deleted the refactor/backend-oauth-metadata-cleanup branch May 24, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant