Enable longitudinal refinement#574
Merged
MaxThevenet merged 17 commits intoSep 8, 2021
Merged
Conversation
This was referenced Jul 28, 2021
Member
|
Thanks for this PR! |
MaxThevenet
reviewed
Sep 7, 2021
Member
MaxThevenet
left a comment
There was a problem hiding this comment.
Thanks for this PR! Just have 1 style comment, which applies to a few places in the code.
| if (pos < patch_lo || pos > patch_hi) continue; | ||
| } | ||
|
|
||
| amrex::MultiFab::Copy( // shift Bx, By |
Member
There was a problem hiding this comment.
I am not sure this is safe across compilers and configurations. Instead of
f( // comment
a, b);Could you do one of these?
f( /* comment */
a, b);
// comment
f(
a, b);
MaxThevenet
approved these changes
Sep 8, 2021
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables longitudinal refinement for the refined level. It is a clean re-opening of #565.
It is based on #572 and should only be reviewed after #572 is merged
Longitudinal is done in the following way:
The beam is binned per level. In the loop over the slices of the coarse grid, a sub-loop over the refined grid is done. For a refinement ratio of 4, 4 sub-slices are calculated.
constisconst)