draft: fix(cudf): Restore NLJ build byte limit and timestamp AST compares - #112
Open
sperlingxx wants to merge 2 commits into
Open
draft: fix(cudf): Restore NLJ build byte limit and timestamp AST compares#112sperlingxx wants to merge 2 commits into
sperlingxx wants to merge 2 commits into
Conversation
The header still declared reserveBuildBytes after the Facebook-main sync dropped the cpp path, so max_build_bytes never threw. Two-sided timestamp comparisons were gated off AST and then failed as a cross-side precompute. Keep the byte-limit test's Values pages as separate GPU batches. Fixes rapidsai#111
This was referenced Sep 1, 2026
sperlingxx
changed the title
Adapters already include the complete CudfNestedLoopJoinBuild type, so a factory wrapper is not needed to restore max_build_bytes accounting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CudfNestedLoopJoinbuild-sidemax_build_bytesaccounting (reserveBuildBytes/ close-time and concat-failure release). The header still declared it after #38 replaced the cpp with upstream; the test added in73a13076etherefore no longer threw.gt(p_ts, b_ts)) as cuDF AST ops instead of a cross-side precompute.innerJoinWithTimestampFilterwas added in635816cbaand failed withsideIdx == -2.velox.cudf.gpu_batch_size_rows=1onbuildByteLimitAndCleanupso the two tiny Values pages stay distinct GPU batches.Test plan
dev28798f623(CUDA SM 86): no throw on the 16-byte cap; timestamp filter throwssideIdx == -2.buildByteLimitAndCleanupandinnerJoinWithTimestampFilterpassed.velox_cudf_nested_loop_join_test: 58/58 passed.Fixes #111
Part of #100
Prepared with assistance from Cursor.