Change file dependency regex to accept absolute paths #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
added a commit
that referenced
this pull request
Apr 5, 2013
Change file dependency regex to accept absolute paths
Member
|
Thanks! |
clayallsopp
added a commit
to rubymotion-community/BubbleWrap
that referenced
this pull request
Feb 16, 2014
This was merged: HipByte/RubyMotion#82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BubbleWrap has had this monkey-patched for ages (currently at here, but originally way back in May 2012).
It allows files to be included with absolute paths (i.e.
/Users/me/.rbenv/gems/BubbleWrap/thing.rbetc). Currently, if a file is included with an absolute path, the old regex will convert it to a relative path (i.e../Users/me/...), which prevents the file from being found and throws anApp.failhere.Would love to see this accepted into the main repo, or an explanation for why it isn't desired :)