[codex] Split leading reasoning blocks#2
Merged
Conversation
HisenWeb
marked this pull request as ready for review
June 24, 2026 19:44
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content.reasoningplus visiblemessageoutput.output_text.Why
Some OpenAI-compatible Chat upstreams may return reasoning embedded at the start of
contentrather than in explicitreasoning_content/reasoningfields. The adapter should preserve that as Responses reasoning output and avoid emitting hidden reasoning as ordinary assistant text.Scope
This keeps the adapter narrow:
codex_chat_common.rsextraction yetcodex_chat_common.rsas a shared helper referenceValidation
Not run locally in this environment. Recommended: