Update workflow-js Cargo.toml for HarmonyOS build#4384
Conversation
rquickjs doesn't ship pre-generated bindings for HarmonyOS/OpenHarmony, need to generate there.
|
Thanks @shenyongqing for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
|
Roadmap triage: this PR is now in v0.9.1 and linked to #2970 as the rquickjs/workflow-js build slice. It does not by itself close the tier-2 target issue; CI, sandbox, clipboard, and docs work remain there. |
|
Thanks @shenyongqing — this is the right narrow shape for the OHOS fix, and I’ve placed it in the v0.9.1 queue. I replayed the commit onto current
All of those pass. Before this is merge-ready, could you please:
I don’t have an OHOS SDK in this review environment, so I’m treating the target check as the remaining proof rather than claiming it from the host-only build. |
|
Retained for v0.9.1. The six-line HarmonyOS rquickjs bindgen change is isolated and still relevant, but this 163-behind head lacks a Signed-off-by line, current-base CI, and an exact OHOS-target build receipt with OHOS_NATIVE_SDK. We should land it as a credited fresh harvest if the contributor branch cannot be updated; #2970 must remain open because this covers only the workflow-js slice. |
|
Hi @shenyongqing — thank you for this contribution! The approach in this PR (activating rquickjs's Rather than merging this PR directly, we've carried your commit onto a maintainer replacement lane in #4459. That lane rebases your work onto current The replacement stays DRAFT until someone produces a real HarmonyOS SDK receipt ( We're leaving this PR open for the steward to close once the replacement lands. Thanks again for the clean fix! 🐋 |
|
Closing with the lineage recorded: the OHOS bindgen approach you pioneered here has landed on main through #4470 (merged), which implements the same You are credited in docs/CONTRIBUTORS.md for the original approach, and the SDK-free bindgen-edge guard from the #4459 review lane is carried forward in #4472. The replacement was needed because the original PR required a rebase plus review-hardening; thank you for the groundwork — the HarmonyOS slice of #2970 is better for it. |
Extend check-ohos-deps.sh with a cargo-tree feature-graph assertion that the OHOS target activates rquickjs's bindgen feature (forwarded to rquickjs-sys) for codewhale-workflow-js — the only reason the crate compiles for a target with no pre-generated QuickJS bindings. Pure metadata: no SDK or target toolchain required. Positive path verified against current main (bindgen landed in Hmbown#4470); negative path verified against a non-OHOS target. Carried over from the Hmbown#4459 review lane; the OHOS bindgen approach was pioneered by @shenyongqing in Hmbown#4384. Signed-off-by: Hunter B <hmbown@gmail.com>
Point Cargo's Windows OHOS linker at a repository-local cmd launcher that delegates to the existing PowerShell clang wrapper. This keeps the target triple, SDK sysroot, and MUSL define on the final Rust link while preserving Cargo's arguments and the native linker exit status. Extend the no-SDK release gate and documentation to protect the full linker and rquickjs bindgen contract. Follow-up evidence from @shenjackyuanjie's PR #4470 completes the Windows linker path alongside @shenyongqing's original bindgen approach in PR #4384. Co-authored-by: shenjackyuanjie <54507071+shenjackyuanjie@users.noreply.github.com> Signed-off-by: Hunter B <hmbown@gmail.com>
|
The remaining Windows final-link wrapper gap from the OHOS bindgen work is now merged in #4503 at |
rquickjs doesn't ship pre-generated bindings for HarmonyOS/OpenHarmony, need to generate there.
Summary
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-featurescargo test --workspace --all-featuresChecklist