Skip to content

Build fix for FreeBSD. - #5254

Closed
mky wants to merge 1 commit into
Hmbown:mainfrom
mky:FreeBSD-fix
Closed

Build fix for FreeBSD.#5254
mky wants to merge 1 commit into
Hmbown:mainfrom
mky:FreeBSD-fix

Conversation

@mky

@mky mky commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

No rquickjs bindings are available for FreeBSD, and compilation stops with the error message:

warning: rquickjs-sys@0.12.1: rquickjs probably doesn't ship bindings for platform x86_64-unknown-freebsd(n/a). try the bindgen feature instead.
error: could not compile rquickjs-sys (lib) due to 1 previous error

This simple patch enable bindings generate for rquickjs on FreeBSD.

Testing

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --all-features --locked (warning-free under the CI allow list)

Two warnings were generated, but I believe not related to my change:

warning: variants Text and Image are never constructed
--> crates/tui/src/tui/clipboard.rs:187:5
warning: this boolean expression can be simplified
--> crates/tui/src/commands/groups/session/structcopy.rs:879:25

Tested with Rust 1.96.0

  • cargo test --workspace --all-features --locked

I cannot test due to a lack of access to all providers. My change should not affect this, it only helps build CodeWhale on FreeBSD.

Checklist

  • Updated docs or comments as needed
  • Added or updated tests where relevant
  • Verified TUI behavior manually if UI changes
  • Harvested/co-authored credit uses a GitHub numeric noreply address

@mky
mky requested a review from Hmbown as a code owner August 6, 2026 22:59
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Thanks @mky for taking the time to contribute.

This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered.

Please read CONTRIBUTING.md for the expected contribution shape. A maintainer can grant recurring PR access by commenting /lgtm on a pull request.

Hmbown pushed a commit that referenced this pull request Aug 7, 2026
Harvested from PR #5254 by @mky

rquickjs ships no pre-generated bindings for FreeBSD, so `rquickjs-sys`
failed to compile there:

  rquickjs probably doesn't ship bindings for platform
  `x86_64-unknown-freebsd(n/a)`. try the `bindgen` feature instead.

Adds the `bindgen` feature for `cfg(target_os = "freebsd")`, mirroring the
NetBSD and Android blocks already directly above and below it — same
shape, same rationale, same comment form.
Co-authored-by: mky <817223+mky@users.noreply.github.com>
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Thanks @mky — your contribution landed in 147e40746425 on main:

Merge FreeBSD build fix

Closing this PR now that the code is on main. Credit lives in the commit message and (where applicable) the CHANGELOG.md entry for the next release. Apologies for not closing this at the time of the merge — the auto-close workflow is new in v0.8.31.

If you want to land more work and would prefer your future PRs merge cleanly without a harvest step, the CONTRIBUTING.md doc has a short note on what makes a contribution mergeable as-is.

@github-actions github-actions Bot closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant