Build fix for FreeBSD. - #5254
Conversation
|
Thanks @mky for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
Harvested from PR #5254 by @mky rquickjs ships no pre-generated bindings for FreeBSD, so `rquickjs-sys` failed to compile there: rquickjs probably doesn't ship bindings for platform `x86_64-unknown-freebsd(n/a)`. try the `bindgen` feature instead. Adds the `bindgen` feature for `cfg(target_os = "freebsd")`, mirroring the NetBSD and Android blocks already directly above and below it — same shape, same rationale, same comment form. Co-authored-by: mky <817223+mky@users.noreply.github.com>
|
Thanks @mky — your contribution landed in
Closing this PR now that the code is on If you want to land more work and would prefer your future PRs merge cleanly without a harvest step, the |
Summary
No rquickjs bindings are available for FreeBSD, and compilation stops with the error message:
This simple patch enable bindings generate for rquickjs on FreeBSD.
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features --locked(warning-free under the CI allow list)Two warnings were generated, but I believe not related to my change:
Tested with Rust 1.96.0
cargo test --workspace --all-features --lockedI cannot test due to a lack of access to all providers. My change should not affect this, it only helps build CodeWhale on FreeBSD.
Checklist