fix(web): make the homepage terminal preview more compact - #5889
Conversation
Cap the terminal at 896px and center it below the introduction, instead of stretching it across the whole 1216px desktop content column. Keep mobile full width and preserve the image aspect ratio. Match Next image sizes to the new display width. Validation: - Website npm test: 407 passed; 0 failed (47 test files). - npm run lint: 0 errors; 2 existing no-img-element warnings in the untouched header and footer. - Browser inspection at 1280px: terminal width 896px. - Browser inspection at 390px: terminal width 343px, no horizontal page overflow; full screenshot and caption preserved. - git diff --check: PASS. The root npm test/check:web scripts are absent from this Rust repository; website-specific checks above were run. This is locally verified source, not a deployment receipt. Leave the tool-generated web/AGENTS.md change unstaged, per the operator-control boundary.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_300ced0a-d695-481b-8eb2-afdcd5c87d37) |
|
Claude finished @Hmbown's task in 1m 12s —— View job Review: homepage terminal preview compaction
Summary Small, well-scoped CSS/markup change (3 lines each file). Verified the mechanics rather than just reading the diff:
No correctness issues, no dead code, no test gaps worth flagging — this is a presentation-only tweak with existing coverage (unit tests unaffected) and the PR's own manual browser verification at 1280px/390px is appropriate evidence for a CSS-only change like this. Nothing here touches provider/model/routing logic. Nit (non-blocking): Looks good to merge from a correctness standpoint. |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are confined to presentational CSS and responsive image hints with low behavioral risk.
Pull request overview
Adjusts the homepage hero “terminal” screenshot presentation so it no longer dominates the desktop content column, while keeping the mobile experience full-width and preserving the screenshot’s aspect ratio. This aligns the hero’s visual hierarchy with the product intro copy and reduces unnecessary image overfetching.
Changes:
- Cap and center the homepage
.folio-shoton desktop (56remmax) while keeping small screens atwidth: 100%. - Update the Next.js
Imagesizeshint to match the new rendered desktop width.
File summaries
| File | Description |
|---|---|
| web/app/globals.css | Centers and caps the hero screenshot width on larger viewports; preserves full-width behavior under 760px. |
| web/app/[locale]/page.tsx | Tightens the Image sizes hint to better match the new max rendered width. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Codewhale review
The PR caps the homepage terminal preview at 896px, centers it, and updates the Next.js responsive image sizes hint to match the new rendered width. The change is presentation-only and retains full-width behavior on small screens.
Assessment
Approved. The CSS cap and the 928px sizes breakpoint align correctly with the existing 2rem page gutters, and the manual browser verification covers the key responsive breakpoints. No automated tests are needed for this visual-only change.
Advisory review by Codewhale (codewhale review --pr 5889 --post, head 762a1c6dae98d2df08bb10c67fbb53bdc4353671). Line-specific findings are also posted as inline review comments; mechanical fixes arrive as committable suggestions you can apply from the Files tab. CODEOWNERS approval still governs merge.
Validation: website tests 407/407 passed; ESLint 0 errors, 2 existing image warnings. Signed-off-by: CodeWhale Bot <bot@codewhale.net>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_c16bb3eb-a74b-4646-955e-be3905d9697d) |
|
Claude finished @Hmbown's task in 1m 25s —— View job Review: homepage terminal preview compaction
Summary This is a small, well-scoped presentational change (2 files, ±3 lines each across two commits). I traced the cascade rather than just reading the diff.
Minor, non-blocking, pre-existing (not introduced by this PR): there's a No correctness bugs, no provider/model/routing concerns (none apply — this is homepage CSS/image-hint only), no dead code introduced, and no test gaps: this is a visual-only change and the PR's manual verification at 1280px/390px is appropriate evidence. Looks good to merge. |
There was a problem hiding this comment.
Codewhale review
The change caps the homepage terminal preview at 56rem on desktop, centers it, and updates the Next Image sizes hint to match the new rendered width. The desktop breakpoint and cap are internally consistent.
Findings
- [INFO] Mobile sizes hint may still overestimate the rendered terminal width (
web/app/[locale]/page.tsx:100)
The updated sizes attribute still uses(max-width: 58rem) calc(100vw - 2rem), 56rem. The PR reports a 390px viewport rendering the terminal at 343px, whilecalc(100vw - 2rem)resolves to 358px. The gap is likely caused by scrollbar width and/or mobile container padding. This only affects responsive asset selection and has no rendering or layout impact, but the value does not precisely match the browser verification measurement.
Assessment
Low-risk presentation-only change. The desktop sizing is correct and matches the CSS cap. The only note is that the mobile sizes value may remain slightly generous for asset selection; no blocking issues.
Advisory review by Codewhale (codewhale review --pr 5889 --post, head 26e0355128b4c4cc5304dcd51affed0bf3c7372e). Line-specific findings are also posted as inline review comments; mechanical fixes arrive as committable suggestions you can apply from the Files tab. CODEOWNERS approval still governs merge.
| width={2760} | ||
| height={1494} | ||
| sizes="(max-width: 1280px) calc(100vw - 2rem), 1248px" | ||
| sizes="(max-width: 58rem) calc(100vw - 2rem), 56rem" |
There was a problem hiding this comment.
[INFO] Mobile sizes hint may still overestimate the rendered terminal width
The updated sizes attribute still uses (max-width: 58rem) calc(100vw - 2rem), 56rem. The PR reports a 390px viewport rendering the terminal at 343px, while calc(100vw - 2rem) resolves to 358px. The gap is likely caused by scrollbar width and/or mobile container padding. This only affects responsive asset selection and has no rendering or layout impact, but the value does not precisely match the browser verification measurement.
Summary
The homepage terminal stretched across the full desktop content column and overwhelmed the introduction. Cap it at 896px and center it; keep mobile full width and preserve the screenshot's aspect ratio. Match the responsive image sizes to the rendered width.
Testing
npm test: 407 passed, 0 failed across 47 files.npm run lint: no errors; two existing image warnings in untouched navigation/footer components.No-Issue: direct founder request to reduce the homepage terminal preview size.
Note
Low Risk
Presentation-only homepage CSS and responsive image hints; no auth, data, or routing changes.
Overview
The homepage hero terminal no longer spans the full content column on desktop. CSS caps
.folio-shotat 56rem (~896px), centers it under the intro copy, and keeps it full width below 760px. The hero grid comment now describes a compact, centered shot rather than a full-column product image.The Next.js
Imagesizesattribute is updated to match (58rem breakpoint, 56rem max) so the browser picks appropriately sized assets for the smaller rendered width.Reviewed by Cursor Bugbot for commit 26e0355. Bugbot is set up for automated code reviews on this repo. Configure here.