fix: align shell guidance with execution - #5900
Open
zhuowp wants to merge 2 commits into
Open
Conversation
Signed-off-by: z27014 <zhuo.wenpei@h3c.com>
Contributor
|
Thanks @zhuowp for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
Signed-off-by: z27014 <zhuo.wenpei@h3c.com>
This was referenced Sep 5, 2026
zhuowp
marked this pull request as ready for review
September 5, 2026 16:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model-visible lowercase bash tool and the legacy Bash handler do not identify the actual interpreter selected by ShellDispatcher. This lets models infer Bash syntax on PowerShell hosts.
Derive cached tool and command guidance from the existing dispatcher for PowerShell, cmd, Bash, POSIX sh, zsh, fish, and custom executable paths. Preserve the visible foreground tool's timeout/output/approval contract, and the hidden legacy tool's blocking wait / wait=false contract. The tool prefix stays stable for the process. Execution, permissions, schema fields, and tool names are unchanged.
Validation on 47c719b:
This complements PowerShell invocation hardening in #4593. The r13 backport is tracked separately in Pinvou#42.
No-Issue: This guidance gap was reproduced during downstream model testing; no matching open upstream issue was identified.