Drop getindex support, Af' returns FactoredMatrix - #10
Merged
Conversation
Formerly `getindex` was supported for `Adjoint{FactoredMatrix}` and
`Transpose{FactoredMatrix}`, but not `FactoredMatrix` itself. Since
`getindex` should not be supported by `Factorization` objects, just
delete these methods.
Also makes the lowercase `adjoint(A)` and `transpose(A)` return
`FactoredMatrix` objects. This was made possible by #9 which generalized
the types for `U` and `V`. Note the uppercase `Adjoint` and `Transpose`
type-wrappers still return the expected types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formerly
getindexwas supported forAdjoint{FactoredMatrix}andTranspose{FactoredMatrix}, but notFactoredMatrixitself. Sincegetindexshould not be supported byFactorizationobjects, just delete these methods. This is a breaking change so the version is bumped to 1.0.0.Also makes the lowercase
adjoint(A)andtranspose(A)returnFactoredMatrixobjects. This was made possible by #9 which generalized the types forUandV. Note the uppercaseAdjointandTransposetype-wrappers still return the expected types.