Skip to content

ingest.yml: set core: true on setup-homebrew - #37

Merged
MikeMcQuaid merged 1 commit into
mainfrom
ingest-core-tap
Aug 3, 2026
Merged

ingest.yml: set core: true on setup-homebrew#37
MikeMcQuaid merged 1 commit into
mainfrom
ingest-core-tap

Conversation

@andrew

@andrew andrew commented Aug 3, 2026

Copy link
Copy Markdown
Member

The ubuntu-latest switch in #29 broke the Match advisories step: setup-homebrew does not clone homebrew/core by default on Linux runners, and brew advisory-match with HOMEBREW_NO_INSTALL_FROM_API=1 requires the local tap.

Failed run: https://github.com/Homebrew/advisory-database/actions/runs/30804352998

Not exercised on this PR since the job is schedule/workflow_dispatch only and guarded to refs/heads/main; will re-dispatch after merge.

The Linux runner switch in ea07339 broke the Match advisories step:
setup-homebrew does not clone homebrew/core by default on Linux, and
advisory-match with HOMEBREW_NO_INSTALL_FROM_API=1 requires the local
tap.
Copilot AI review requested due to automatic review settings August 3, 2026 10:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the scheduled ingest workflow to ensure brew advisory-match can run on Linux runners when HOMEBREW_NO_INSTALL_FROM_API=1 is set, by explicitly cloning the homebrew/core tap during Homebrew setup.

Changes:

  • Configure Homebrew/actions/setup-homebrew in the ingest workflow to fetch homebrew/core (core: true).

馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@andrew
andrew requested a review from MikeMcQuaid August 3, 2026 10:14

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
MikeMcQuaid merged commit a040f8e into main Aug 3, 2026
8 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the ingest-core-tap branch August 3, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants