Skip to content

dev-cmd/pr-automerge: exclude draft PRs#10028

Merged
bayandin merged 1 commit intoHomebrew:masterfrom
bayandin:do-not-automerge-draft-prs
Dec 15, 2020
Merged

dev-cmd/pr-automerge: exclude draft PRs#10028
bayandin merged 1 commit intoHomebrew:masterfrom
bayandin:do-not-automerge-draft-prs

Conversation

@bayandin
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This PR prevents draft PRs to be merged by pr-automerge.

By now, there are only 2 PR were automatically merged being a draft: Homebrew/homebrew-core#61327 and Homebrew/homebrew-core#64346 (see query).

I'm not sure if we need to add a flag to override this behaviour (as we have --without-approval).

@bayandin bayandin changed the title dev-cmd/pr-automerge: exclude draft PR dev-cmd/pr-automerge: exclude draft PRs Dec 15, 2020
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2020-12-16 at 12:34:16 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 15, 2020
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 15, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 15, 2020
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Dec 15, 2020

Review period ended.

@bayandin bayandin merged commit 3e53d5b into Homebrew:master Dec 15, 2020
@bayandin bayandin deleted the do-not-automerge-draft-prs branch December 15, 2020 16:02
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 15, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants