Skip to content

brew.sh: define minimum required Glibc version#10040

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
maxim-belkin:glibc-central
Dec 24, 2020
Merged

brew.sh: define minimum required Glibc version#10040
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
maxim-belkin:glibc-central

Conversation

@maxim-belkin
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Define minimum required Glibc version in one central location -- brew.sh

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2020-12-17 at 23:46:28 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 16, 2020
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxim-belkin! Looking good, just had some ideas on making this robust to future refactoring.

Comment thread Library/Homebrew/cmd/vendor-install.sh Outdated
Comment thread Library/Homebrew/brew.sh Outdated
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 Perfect, thanks @maxim-belkin!

@maxim-belkin
Copy link
Copy Markdown
Contributor Author

Thanks for the review, Mike!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 18, 2020
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit d89a2c1 into Homebrew:master Dec 24, 2020
@maxim-belkin maxim-belkin deleted the glibc-central branch December 24, 2020 16:18
@sjackman
Copy link
Copy Markdown
Contributor

Thanks, Maxim!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 24, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

linux outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants