rubocops: add unless_multiple_conditions#10256
Merged
SeekingMeaning merged 2 commits intoHomebrew:masterfrom Jan 9, 2021
Merged
rubocops: add unless_multiple_conditions#10256SeekingMeaning merged 2 commits intoHomebrew:masterfrom
unless_multiple_conditions#10256SeekingMeaning merged 2 commits intoHomebrew:masterfrom
Conversation
Contributor
|
Review period will end on 2021-01-08 at 23:12:39 UTC. |
5 tasks
SeekingMeaning
commented
Jan 7, 2021
Library/Homebrew/test/rubocops/unless_multiple_conditions_spec.rb
Outdated
Show resolved
Hide resolved
f63fc01 to
be2406d
Compare
MikeMcQuaid
approved these changes
Jan 8, 2021
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Great work here as usual @SeekingMeaning and impressive turnaround on this 👏🏻
be2406d to
2a80427
Compare
Contributor
|
Review period ended. |
BrewTestBot
approved these changes
Jan 9, 2021
Member
|
@SeekingMeaning Looks like we may be able to replace this with rubocop/rubocop#9386 after the next RuboCop release? 🤞🏻 |
Contributor
Author
|
Opened #10770 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?Follow-up to #10245 (comment)
This PR adds the
UnlessMultipleConditionsrubocop, based on rubocop/rubocop#5400unlesswithifhomebrew-core#68527Disallowed
unlessstatements:Truth table for reference: