Skip to content

rubocops: use Style/UnlessLogicalOperators#10770

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:unless_logical_operators
Mar 5, 2021
Merged

rubocops: use Style/UnlessLogicalOperators#10770
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:unless_logical_operators

Conversation

@SeekingMeaning
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This replaces Style/UnlessMultipleConditions, which was added in #10256

The autocorrect part of UnlessMultipleConditions has been adapted for UnlessLogicalOperators in a pending PR: rubocop/rubocop#9553

Replaces `Style/UnlessMultipleConditions`
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-03-04 at 09:51:25 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 3, 2021
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 ❤️ ➖

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 4, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit 61427d6 into Homebrew:master Mar 5, 2021
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @SeekingMeaning!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Apr 5, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants