Skip to content

pr-upload: Fix a typo affecting Internet Archive#10697

Merged
sjackman merged 1 commit intoHomebrew:masterfrom
sjackman:sj/pr-upload
Feb 25, 2021
Merged

pr-upload: Fix a typo affecting Internet Archive#10697
sjackman merged 1 commit intoHomebrew:masterfrom
sjackman:sj/pr-upload

Conversation

@sjackman
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fix a typo in pr-upload affecting Internet Archive. Not sure how this typo slipped in. Sigh

@sjackman sjackman added the bug label Feb 24, 2021
@sjackman sjackman self-assigned this Feb 24, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-02-25 at 23:08:51 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 24, 2021
@sjackman sjackman added the critical Critical change which should be shipped as soon as possible. label Feb 24, 2021
@sjackman sjackman enabled auto-merge February 24, 2021 23:09
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 24, 2021
@sjackman
Copy link
Copy Markdown
Contributor Author

CI / test everything (macOS) (pull_request)

  brew audit --skip-style
audit for lg-onscreen-control: failed
 - cannot use the sha256 for an empty string: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
 - Cask should have a description. Please add a `desc` stanza.

https://github.com/Homebrew/brew/pull/10697/checks?check_run_id=1974574815#step:12:8
😕

@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Feb 24, 2021

https://github.com/Homebrew/homebrew-cask-drivers/pull/2056

@sjackman sjackman merged commit ac2c9df into Homebrew:master Feb 25, 2021
@sjackman sjackman deleted the sj/pr-upload branch February 25, 2021 00:26
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 28, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants