Skip to content

Let bin/brew handle its own exporting#10764

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Bo98:export-env
Mar 4, 2021
Merged

Let bin/brew handle its own exporting#10764
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Bo98:export-env

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Mar 2, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

If HOMEBREW_NO_ENV_FILTERING is not set, then /usr/bin/env already exports these. For consistency, we should be doing the same if HOMEBREW_NO_ENV_FILTERING is set.

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-03-03 at 17:02:13 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 2, 2021
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Mar 2, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit cca1413 into Homebrew:master Mar 4, 2021
@Bo98 Bo98 deleted the export-env branch March 4, 2021 15:45
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Apr 4, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants