Skip to content

formula_auditor: add audit for formulae with synced versions#12279

Merged
bayandin merged 1 commit intoHomebrew:masterfrom
bayandin:synced-versions-formulae
Nov 19, 2021
Merged

formula_auditor: add audit for formulae with synced versions#12279
bayandin merged 1 commit intoHomebrew:masterfrom
bayandin:synced-versions-formulae

Conversation

@bayandin
Copy link
Copy Markdown
Contributor

@bayandin bayandin commented Oct 20, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We have a bunch of formulae in homebrew-core that are supposed to be updated simultaneously (like git and git-gui, python@3.9 and python-tk@3.9 and recently added libnghttp2 and nghttp2) and usually, we keep this requirement as a comment in formulae and check it manually during a PR review.

I propose adding a list (synced_versions_formulae.json) of such formulae to homebrew-core and an audit for checking those particular formulae have the same version.

The current version of synced_versions_formulae.json will look like this:

[
  ["cmake", "cmake-docs"],
  ["etl", "synfig"],
  ["fizz", "folly", "wangle", "watchman"],
  ["git", "git-credential-libsecret", "git-gui"],
  ["ilmbase", "openexr@2"],
  ["imath", "openexr"],
  ["libnghttp2", "nghttp2"],
  ["libqalculate", "qalculate-gtk"],
  ["mame", "rom-tools"],
  ["moarvm", "nqp", "rakudo"],
  ["python@3.10", "python-tk@3.10"],
  ["python@3.9", "python-tk@3.9"]
]

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-10-21 at 19:26:13 UTC.

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Oct 20, 2021
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea 👏🏻

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Oct 21, 2021
@carlocab
Copy link
Copy Markdown
Member

There's also file-formula and libmagic. Just leaving a note here in case I miss synced_versions_formulae.json being added to Homebrew/core.

Copy link
Copy Markdown
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Love it, thanks!

Comment thread Library/Homebrew/formula_auditor.rb
@bayandin
Copy link
Copy Markdown
Contributor Author

Adding a list of such formulae to homebrew-core Homebrew/homebrew-core#87990

@bayandin bayandin enabled auto-merge October 28, 2021 12:13
@bayandin bayandin requested a review from Rylan12 October 28, 2021 12:22
@bayandin bayandin disabled auto-merge October 28, 2021 13:02
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@bayandin
Copy link
Copy Markdown
Contributor Author

Actually, before merging it, I need to sort out first, how to handle brew bump-formula-pr for such formulae first.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Nov 19, 2021
@bayandin bayandin added in progress Maintainers are working on this and removed stale No recent activity labels Nov 19, 2021
@carlocab
Copy link
Copy Markdown
Member

Can we either punt on bump-formula-pr or revert Homebrew/homebrew-core#87990? I'd either like this audit in place or the comments about syncing versions back.

@bayandin
Copy link
Copy Markdown
Contributor Author

Can we either punt on bump-formula-pr or revert Homebrew/homebrew-core#87990? I'd either like this audit in place or the comments about syncing versions back.

Sorry about it 😞
Wasn't able to make a trivial change to brew-formula-pr straight away to handle this. I'll have another look at the PR this weekend and will try to come with some solution otherwise will revert that changes.

@MikeMcQuaid
Copy link
Copy Markdown
Member

Wasn't able to make a trivial change to brew-formula-pr straight away to handle this. I'll have another look at the PR this weekend and will try to come with some solution otherwise will revert that changes.

Just merge this PR as-is IMO. brew bump-formula-pr work can be a follow-up PR and/or help wanted issue.

@bayandin bayandin removed do not merge in progress Maintainers are working on this labels Nov 19, 2021
@bayandin bayandin enabled auto-merge November 19, 2021 12:24
@bayandin bayandin merged commit 27a7629 into Homebrew:master Nov 19, 2021
@bayandin bayandin deleted the synced-versions-formulae branch November 19, 2021 12:24
@bayandin
Copy link
Copy Markdown
Contributor Author

bayandin commented Nov 19, 2021

And Homebrew/homebrew-core#89694 fixes the audit failure

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants