Skip to content

formula_auditor: ignore implicit dep for Linux gcc audit#21765

Merged
MikeMcQuaid merged 1 commit intomainfrom
audit-gcc-ignore-implicit
Mar 19, 2026
Merged

formula_auditor: ignore implicit dep for Linux gcc audit#21765
MikeMcQuaid merged 1 commit intomainfrom
audit-gcc-ignore-implicit

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Mar 19, 2026

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Implicit GCC is from running an OS with older system GCC and shouldn't cause audit failure.

Copilot AI review requested due to automatic review settings March 19, 2026 13:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Linux-only GCC dependency audit in FormulaAuditor to ignore implicit gcc dependencies (e.g., coming from older system toolchains) so they don’t incorrectly trigger audit failures.

Changes:

  • Treat gcc as relevant to the Linux-only audit only when it is a non-implicit dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main with commit 3cf4028 Mar 19, 2026
42 checks passed
@MikeMcQuaid MikeMcQuaid deleted the audit-gcc-ignore-implicit branch March 19, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants