Skip to content

test/linux_runner_spec_spec: use unversioned container#21769

Merged
MikeMcQuaid merged 1 commit intomainfrom
linux_runner_spec_spec-test
Mar 19, 2026
Merged

test/linux_runner_spec_spec: use unversioned container#21769
MikeMcQuaid merged 1 commit intomainfrom
linux_runner_spec_spec-test

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Mar 19, 2026

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

This test doesn't verify anything related to Homebrew's CI versions so can use the unversioned container to minimize migration diff.

This test doesn't verify anything related to Homebrew's CI versions so
can use the unversioned container to minimize migration diff.
Copilot AI review requested due to automatic review settings March 19, 2026 16:17
@cho-m cho-m mentioned this pull request Mar 19, 2026
17 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the LinuxRunnerSpec unit test fixture to use an unversioned Homebrew container image, reducing churn when CI base images (e.g., Ubuntu versions) change elsewhere in the codebase.

Changes:

  • Switch the test’s container.image from ghcr.io/homebrew/ubuntu22.04:main to ghcr.io/homebrew/brew:main.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main with commit 1435237 Mar 19, 2026
42 checks passed
@MikeMcQuaid MikeMcQuaid deleted the linux_runner_spec_spec-test branch March 19, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants