Skip to content

dev-cmd/tap-new: use ubuntu-latest + ghcr.io/homebrew/brew:main#21780

Merged
MikeMcQuaid merged 1 commit intomainfrom
tap-new-unversioned
Mar 20, 2026
Merged

dev-cmd/tap-new: use ubuntu-latest + ghcr.io/homebrew/brew:main#21780
MikeMcQuaid merged 1 commit intomainfrom
tap-new-unversioned

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Mar 19, 2026

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Similar to how we run in homebrew/core, set up tap with ubuntu-latest and ghcr.io/homebrew/brew:main which reduce 3rd party maintenance after migration or after GitHub drops support for older Ubuntu.

Would still need to update macOS versions but unavoidable as Intel macOS only has versioned runner labels.


Can't comment on performance. May be slower due to fetching container.

Copilot AI review requested due to automatic review settings March 19, 2026 22:48
@cho-m cho-m mentioned this pull request Mar 19, 2026
17 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the brew tap-new generated GitHub Actions workflows to follow Homebrew’s current Linux CI pattern by using the floating ubuntu-latest runner with the ghcr.io/homebrew/brew:main container, reducing maintenance when GitHub deprecates specific Ubuntu runner versions.

Changes:

  • Switch the generated tests.yml Linux job to run on ubuntu-latest using ghcr.io/homebrew/brew:main via a matrix include.
  • Switch the generated publish.yml (pr-pull) job to ubuntu-latest and run inside ghcr.io/homebrew/brew:main.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cho-m cho-m marked this pull request as draft March 19, 2026 22:57
@cho-m cho-m force-pushed the tap-new-unversioned branch from d5ed106 to 868fdf2 Compare March 19, 2026 23:28
@cho-m cho-m marked this pull request as ready for review March 19, 2026 23:28
@cho-m cho-m requested a review from Copilot March 19, 2026 23:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 84823c5 Mar 20, 2026
42 checks passed
@MikeMcQuaid MikeMcQuaid deleted the tap-new-unversioned branch March 20, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants