Skip to content

Use ubuntu-latest and add constant for arm linux runner#21787

Merged
cho-m merged 1 commit intomainfrom
ubuntu-runners
Mar 20, 2026
Merged

Use ubuntu-latest and add constant for arm linux runner#21787
cho-m merged 1 commit intomainfrom
ubuntu-runners

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Mar 20, 2026

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

For ubuntu-latest:

  • Not sure why dispatch bottle is using ubuntu-22.04 when all other workflows use ubuntu-latest so switched it
  • Trying out if it works for Cask CI. Can switch this one back if any issues.

For ubuntu-22.04-arm:

Copilot AI review requested due to automatic review settings March 20, 2026 19:15
@cho-m cho-m mentioned this pull request Mar 20, 2026
17 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns Linux GitHub Actions runner labels across Homebrew developer commands and runner-matrix generation by switching x86_64 Linux to ubuntu-latest and centralizing the ARM Linux runner label behind a reusable constant.

Changes:

  • Switch Linux x86_64 runner label from ubuntu-22.04 to ubuntu-latest in cask CI matrix generation and bottle-dispatch logic.
  • Introduce OS::LINUX_CI_ARM_RUNNER (ubuntu-22.04-arm) and use it wherever the ARM Linux runner label is needed.
  • Update affected specs to match the new runner labels/constant usage.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Library/Homebrew/test/dev-cmd/generate-cask-ci-matrix_spec.rb Updates expectations to use ubuntu-latest for x86_64 and the new ARM runner constant.
Library/Homebrew/test/dev-cmd/determine-test-runners_spec.rb Uses the new ARM runner constant in test runner lists/env setup.
Library/Homebrew/os.rb Adds OS::LINUX_CI_ARM_RUNNER constant for reuse.
Library/Homebrew/github_runner_matrix.rb Replaces hardcoded ARM runner label with OS::LINUX_CI_ARM_RUNNER.
Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb Switches x86_64 Linux to ubuntu-latest and uses OS::LINUX_CI_ARM_RUNNER for ARM.
Library/Homebrew/dev-cmd/dispatch-build-bottle.rb Switches Linux x86_64 to ubuntu-latest and uses OS::LINUX_CI_ARM_RUNNER for ARM dispatch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@cho-m cho-m added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 8756b29 Mar 20, 2026
38 checks passed
@cho-m cho-m deleted the ubuntu-runners branch March 20, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants