Use ubuntu-latest and add constant for arm linux runner#21787
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns Linux GitHub Actions runner labels across Homebrew developer commands and runner-matrix generation by switching x86_64 Linux to ubuntu-latest and centralizing the ARM Linux runner label behind a reusable constant.
Changes:
- Switch Linux x86_64 runner label from
ubuntu-22.04toubuntu-latestin cask CI matrix generation and bottle-dispatch logic. - Introduce
OS::LINUX_CI_ARM_RUNNER(ubuntu-22.04-arm) and use it wherever the ARM Linux runner label is needed. - Update affected specs to match the new runner labels/constant usage.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/test/dev-cmd/generate-cask-ci-matrix_spec.rb | Updates expectations to use ubuntu-latest for x86_64 and the new ARM runner constant. |
| Library/Homebrew/test/dev-cmd/determine-test-runners_spec.rb | Uses the new ARM runner constant in test runner lists/env setup. |
| Library/Homebrew/os.rb | Adds OS::LINUX_CI_ARM_RUNNER constant for reuse. |
| Library/Homebrew/github_runner_matrix.rb | Replaces hardcoded ARM runner label with OS::LINUX_CI_ARM_RUNNER. |
| Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb | Switches x86_64 Linux to ubuntu-latest and uses OS::LINUX_CI_ARM_RUNNER for ARM. |
| Library/Homebrew/dev-cmd/dispatch-build-bottle.rb | Switches Linux x86_64 to ubuntu-latest and uses OS::LINUX_CI_ARM_RUNNER for ARM dispatch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?For ubuntu-latest:
ubuntu-22.04when all other workflows useubuntu-latestso switched itFor ubuntu-22.04-arm: