sorbet: Bump test/support/helper files to typed: true#22469
Merged
Conversation
MikeMcQuaid
approved these changes
May 30, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks, looks good when 🟢!
Member
Author
|
TIL that |
814af41 to
ff303ca
Compare
- Add `T.bind`s for RSpec example groups and matcher test helpers. - For the undefined predicate method raising NoMethodError, trick Sorbet into not flagging it as an error by using `public_send` instead of direct method call - because, correctly, the method does not exist but the test is already verifying that.
ff303ca to
0b1f3c4
Compare
Code Coverage OverviewLanguages: Ruby Ruby / code-coverage/simplecovThe overall coverage in the branch remains at 78%, unchanged from the branch. Show a code coverage summary of the most impacted files.
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?T.untypedandT.unsafe(particularlyLibrary/Homebrew/test/support/helper/subcommand_spec.rb).T.binds for RSpec example groups and matcher test helpers.public_sendinstead of direct method call - because, correctly, the method does not exist but the test is already verifying that.