Skip to content

Refine tap trust warnings#22503

Merged
MikeMcQuaid merged 1 commit into
mainfrom
adaptive-bladder
Jun 1, 2026
Merged

Refine tap trust warnings#22503
MikeMcQuaid merged 1 commit into
mainfrom
adaptive-bladder

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Jun 1, 2026

Fixes #22494

  • keep brew doctor visibility while moving install-time hints to non-fatal preinstall diagnostics
  • document why explicit trust matters before the default changes in Homebrew 6.0.0 or 5.2.0
  • clean untrusted hosted-runner taps before test-bot setup so unrelated runner state does not fail brew doctor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.5 xhigh with local review and testing.


@MikeMcQuaid MikeMcQuaid force-pushed the adaptive-bladder branch 2 times, most recently from 0e8ca67 to 0496f39 Compare June 1, 2026 17:02
@github-code-quality
Copy link
Copy Markdown

github-code-quality Bot commented Jun 1, 2026

Code Coverage Overview

Languages: Ruby

Ruby / code-coverage/simplecov

The overall coverage in the branch remains at 78%, unchanged from the branch.

Show a code coverage summary of the most impacted files.
File 63f2962 717fc4b +/-
trust.rb 88% 88% 0%
install.rb 71% 71% 0%
diagnostic.rb 53% 54% +1%
utils/tty.rb 91% 92% +1%
bundle/extensio...de_extension.rb 98% 99% +1%
download_queue.rb 73% 74% +1%
test_bot/cleanup_before.rb 47% 59% +12%

Updated June 01, 2026 18:47 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@MikeMcQuaid MikeMcQuaid enabled auto-merge June 1, 2026 17:21
- keep `brew doctor` visibility while moving install-time hints to
  non-fatal preinstall diagnostics
- document why explicit trust matters before the default changes in
  Homebrew 6.0.0 or 5.2.0
- clean untrusted hosted-runner taps before test-bot setup so unrelated
  runner state does not fail `brew doctor`
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit 43039a4 Jun 1, 2026
46 checks passed
@MikeMcQuaid MikeMcQuaid deleted the adaptive-bladder branch June 1, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew doctor untrusted-tap check fails test-bot CI for third-party taps (regression from #22470)

2 participants