Skip to content

Skip sandbox setup for syntax-only jobs#22507

Merged
MikeMcQuaid merged 1 commit into
mainfrom
test-bot-sandbox-only-flags
Jun 2, 2026
Merged

Skip sandbox setup for syntax-only jobs#22507
MikeMcQuaid merged 1 commit into
mainfrom
test-bot-sandbox-only-flags

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

  • Avoid Bubblewrap configuration for test-bot modes that do not run sandboxed formula install or test commands.
  • Keep sandbox setup for formula-only jobs because they can execute sandboxed formula work.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.5 xhigh with local review.


@github-code-quality
Copy link
Copy Markdown

github-code-quality Bot commented Jun 1, 2026

Code Coverage Overview

Languages: Ruby

Ruby / code-coverage/simplecov

The overall coverage in the branch remains at 78%, unchanged from the branch.

Show a code coverage summary of the most impacted files.
File 513c3d2 9a91b09 +/-
services/system.rb 85% 81% -4%
services/cli.rb 63% 61% -2%
bundle/extensio...de_extension.rb 99% 98% -1%
test_bot.rb 88% 93% +5%
services/system/systemctl.rb 87% 93% +6%

Updated June 02, 2026 14:34 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@MikeMcQuaid MikeMcQuaid enabled auto-merge June 2, 2026 11:57
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 2, 2026
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 2, 2026
@MikeMcQuaid MikeMcQuaid force-pushed the test-bot-sandbox-only-flags branch from 2e8d88a to fe13ae3 Compare June 2, 2026 13:34
- Avoid Bubblewrap configuration for `test-bot` modes that do not
  run sandboxed formula install or test commands.
- Keep sandbox setup for formula-only jobs because they can execute
  sandboxed formula work.
- Cover rebased strict doubles that now exercise this decision.
@MikeMcQuaid MikeMcQuaid force-pushed the test-bot-sandbox-only-flags branch from fe13ae3 to 9a91b09 Compare June 2, 2026 14:15
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit 53d2800 Jun 2, 2026
38 checks passed
@MikeMcQuaid MikeMcQuaid deleted the test-bot-sandbox-only-flags branch June 2, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants