Skip to content

Create service path directories#22512

Open
MikeMcQuaid wants to merge 1 commit into
mainfrom
services-create-path-dirs
Open

Create service path directories#22512
MikeMcQuaid wants to merge 1 commit into
mainfrom
services-create-path-dirs

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

Fixes #22501

  • Avoid service startup failures when explicit DSL paths need dirs
  • Keep creation scoped to service block path fields
  • Cover path inference and load-time creation in service specs

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.5 xhigh with local review and testing.


@github-code-quality
Copy link
Copy Markdown

github-code-quality Bot commented Jun 2, 2026

Code Coverage Overview

Languages: Ruby

Ruby / code-coverage/simplecov

The overall coverage in the branch is 78%. The coverage in the branch is 74%.

Show a code coverage summary of the most impacted files.
File 53d2800 de90a6f +/-
cask/cask_loader.rb 65% 96% +31%
cask/audit.rb 25% 63% +38%
extend/os/mac/keg_relocate.rb 0% 55% +55%
extend/os/mac/diagnostic.rb 0% 57% +57%
cask/artifact/a...ct_uninstall.rb 32% 89% +57%
cask/installer.rb 28% 91% +63%
os/mac/xcode.rb 0% 70% +70%
extend/os/mac/e...nd/ENV/super.rb 0% 91% +91%
extend/os/mac/sandbox.rb 0% 92% +92%
cask/info.rb 0% 96% +96%

Updated June 02, 2026 15:21 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

- Avoid service startup failures when explicit DSL paths need dirs
- Keep creation scoped to `service` block path fields
- Flag redundant service path setup in formula audits
- Cover path inference, load-time creation and audit cleanup
@MikeMcQuaid MikeMcQuaid force-pushed the services-create-path-dirs branch from 82d371d to de90a6f Compare June 2, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Brew should automatically create the paths used in service blocks

1 participant