Skip to content

Add rebuild step RuboCop checks#22515

Draft
MikeMcQuaid wants to merge 2 commits into
mainfrom
install-step-rebuild-rubocops
Draft

Add rebuild step RuboCop checks#22515
MikeMcQuaid wants to merge 2 commits into
mainfrom
install-step-rebuild-rubocops

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

  • defer autocorrection until rebuild actions are in stable releases
  • keep cask audits limited to cask-supported step methods
  • catch exact formula cache rebuild patterns conservatively

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.5 xhigh with local review and testing.


- avoid Ruby-only `post_install` for common desktop cache rebuilds
- keep API steps structured instead of serialising raw commands
- document the stable runtime surface before lint conversions
- defer autocorrection until rebuild actions are in stable releases
- keep cask audits limited to cask-supported step methods
- catch exact formula cache rebuild patterns conservatively
@MikeMcQuaid MikeMcQuaid marked this pull request as draft June 2, 2026 16:34
@github-code-quality
Copy link
Copy Markdown

github-code-quality Bot commented Jun 2, 2026

Code Coverage Overview

Languages: Ruby

Ruby / code-coverage/simplecov

The overall coverage in the branch remains at 78%, unchanged from the branch.

Show a code coverage summary of the most impacted files.
File 53d2800 b56e9b5 +/-
test_bot.rb 93% 88% -5%
services/system.rb 85% 81% -4%
services/cli.rb 63% 61% -2%
rubocops/shared...steps_helper.rb 97% 97% 0%
install_steps.rb 92% 94% +2%
services/system/systemctl.rb 87% 93% +6%

Updated June 02, 2026 16:53 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@MikeMcQuaid MikeMcQuaid force-pushed the install-step-rebuild-actions branch from 4079bd0 to 1618f7c Compare June 2, 2026 16:51
Base automatically changed from install-step-rebuild-actions to main June 2, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant