sorbet: Bump more tests to `typed: true` by issyl0 · Pull Request #22532 · Homebrew/brew

issyl0 · 2026-06-03T23:07:48Z

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
Have you written new tests (excluding integration tests) for your changes? Here's an example.
Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

AI was used to generate or assist with generating this PR.

I had these changes hanging around locally since the weekend, so here they are.
See commit messages for more details.

- `File.delete` expects a `String` or `Pathname`, but the test was passing it a `File`.

- `__dir__` is always a String, but Sorbet can't tell that.

- The `env` test is testing the BuildEnvironment env.

- Follow up to 8862004. - Also slim down the comments added in that commit, as it was too verbose to put everywhere else.

github-code-quality · 2026-06-03T23:29:21Z

Code Coverage Overview

Languages: Ruby

Ruby / code-coverage/simplecov

The overall coverage in the sorbet-yet-more-test... branch remains at 78%, unchanged from the main branch.

Show a code coverage summary of the most impacted files.

File	main `c6a08de`	sorbet-yet-more-test... 4a4b06c	+/-
`utils/tty.rb`	92%	91%	-1%
`download_queue.rb`	74%	73%	-1%
`bundle/cask.rb`	97%	97%	0%
`bundle/tap.rb`	98%	98%	0%
`bundle/brew.rb`	98%	98%	0%
`trust.rb`	88%	89%	+1%
`extend/pathname.rb`	75%	79%	+4%
`services/cli.rb`	62%	67%	+5%

_{Updated June 03, 2026 23:34 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.}

Copilot

Pull request overview

This PR continues the Sorbet adoption effort in Homebrew/brew by raising Sorbet strictness in a number of spec files and adding minimal scaffolding (dummy lets and RBI shims) so those tests typecheck cleanly.

Changes:

Bump multiple RSpec files from typed: false to typed: true (and one to typed: strict) and add Sorbet-friendly dummy let defaults where needed.
Add/adjust Sorbet annotations in specs (e.g., T.must(__dir__), T.bind) to satisfy type inference.
Extend the RSpec shim RBI to include additional Formula DSL methods used in typed specs.

Show a summary per file

File	Description
Library/Homebrew/test/utils/user_spec.rb	Condenses Sorbet-only dummy `let` commentary to an inline note.
Library/Homebrew/test/utils/string_inreplace_extension_spec.rb	Simplifies Sorbet dummy `let` explanation into an inline comment.
Library/Homebrew/test/utils/ruby_check_version_script_spec.rb	Converts multi-line Sorbet dummy `let` note into an inline comment.
Library/Homebrew/test/system_command_result_spec.rb	Bumps to `typed: true` and adds a Sorbet dummy `stdout` `let` for typechecking.
Library/Homebrew/test/services/formula_wrapper_spec.rb	Bumps to `typed: true` and adjusts a stub to satisfy Sorbet typing.
Library/Homebrew/test/install_spec.rb	Bumps from `typed: true` to `typed: strict`.
Library/Homebrew/test/dev-cmd/lgtm_spec.rb	Bumps to `typed: true` and adds `T.must` around `__dir__` for Sorbet.
Library/Homebrew/test/cmd/update_spec.rb	Bumps to `typed: true` and adds `T.must` around `__dir__` for Sorbet.
Library/Homebrew/test/cmd/bundle/remove_subcommand_spec.rb	Bumps to `typed: true` and introduces Sorbet-only dummy `let`s for inferred values.
Library/Homebrew/test/cleaner_spec.rb	Bumps to `typed: true`.
Library/Homebrew/test/cask/dsl/container_spec.rb	Bumps to `typed: true` and adds dummy `params` `let` for Sorbet.
Library/Homebrew/test/cask/dsl_spec.rb	Simplifies Sorbet dummy `let` explanation into an inline comment.
Library/Homebrew/test/cask/depends_on_spec.rb	Bumps to `typed: true` and adds dummy `cask` `let` for Sorbet in top-level subject.
Library/Homebrew/test/cask/artifact/zshcompletion_spec.rb	Bumps to `typed: true` and adds dummy `cask_token` `let` for Sorbet.
Library/Homebrew/test/cask/artifact/manpage_spec.rb	Bumps to `typed: true` and adds dummy `cask_token` `let` for Sorbet.
Library/Homebrew/test/cask/artifact/fishlcompletion_spec.rb	Bumps to `typed: true` and adds dummy `cask_token` `let` for Sorbet.
Library/Homebrew/test/cask/artifact/bashcompletion_spec.rb	Bumps to `typed: true` and adds dummy `cask_token` `let` for Sorbet.
Library/Homebrew/test/bundle/bundle_spec.rb	Bumps to `typed: true` and adds dummy `brewfile_content` `let` for Sorbet.
Library/Homebrew/test/build_environment_spec.rb	Adds a `T.bind` in a class body to help Sorbet infer the DSL receiver.
Library/Homebrew/sorbet/rbi/shims/rspec.rbi	Extends shims to include `Formula#keg_only` and `Formula#skip_clean` for typed spec DSL blocks.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files not reviewed (1)

Library/Homebrew/sorbet/rbi/shims/rspec.rbi: Language not supported

Files reviewed: 19/20 changed files
Comments generated: 1

      tempfile = File.new("/tmp/foo", File::CREAT)
-      allow(service).to receive_messages(installed?: true, service_file: Pathname.new(tempfile))
+      allow(service).to receive_messages(installed?: true, service_file: tempfile_path = Pathname.new(tempfile))
      expect(service.plist?).to be(true)
-      File.delete(tempfile)
+      File.delete(tempfile_path)


MikeMcQuaid

Thanks! Same comment as previous PR.

MikeMcQuaid · 2026-06-04T07:58:44Z


 # Some helper blocks are inferred as Formula instances or class contexts.
 class Formula
+  sig { params(reason: T.any(String, Symbol), explanation: String).void }


As in the other PR: let's cast to Formula in relevant places and remove this here.

issyl0 force-pushed the sorbet-yet-more-tests branch from 6219e70 to 5577f1e Compare June 3, 2026 23:12

issyl0 added 4 commits June 4, 2026 00:15

test/services/formula_wrapper: Bump to Sorbet typed: true

1af8668

- `File.delete` expects a `String` or `Pathname`, but the test was passing it a `File`.

sorbet: T.must(__dir__) gets us a couple more tests typechecked

80dd762

- `__dir__` is always a String, but Sorbet can't tell that.

test/build_environment: Bump to Sorbet typed: true

b5a6ceb

- The `env` test is testing the BuildEnvironment env.

sorbet: More dummy lets in tests for before blocks etc

4a4b06c

- Follow up to 8862004. - Also slim down the comments added in that commit, as it was too verbose to put everywhere else.

issyl0 force-pushed the sorbet-yet-more-tests branch from 5577f1e to 4a4b06c Compare June 3, 2026 23:19

issyl0 marked this pull request as ready for review June 3, 2026 23:34

Copilot AI review requested due to automatic review settings June 3, 2026 23:34

Copilot started reviewing on behalf of issyl0 June 3, 2026 23:34 View session

issyl0 enabled auto-merge June 3, 2026 23:35

Copilot AI reviewed Jun 3, 2026

View reviewed changes

MikeMcQuaid reviewed Jun 4, 2026

View reviewed changes

issyl0 closed this Jun 4, 2026

auto-merge was automatically disabled June 4, 2026 10:41
Pull request was closed

issyl0 mentioned this pull request Jun 4, 2026

sorbet: Bump more tests to typed: true #22542

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

sorbet: Bump more tests to `typed: true`#22532

sorbet: Bump more tests to `typed: true`#22532
issyl0 wants to merge 4 commits into
mainfrom
sorbet-yet-more-tests

issyl0 commented Jun 3, 2026

Uh oh!

github-code-quality Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

MikeMcQuaid left a comment

Uh oh!

MikeMcQuaid Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

issyl0 commented Jun 3, 2026

Uh oh!

github-code-quality Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

Ruby / code-coverage/simplecov

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

MikeMcQuaid left a comment

Choose a reason for hiding this comment

Uh oh!

MikeMcQuaid Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-code-quality Bot commented Jun 3, 2026 •

edited

Loading