Skip untrusted cleanup formulae#22553
Merged
Merged
Conversation
- Avoid aborting `brew cleanup` when cache checks cannot load an installed formula from an untrusted tap. - Warn that the tap formula is not trusted so users know why cleanup skipped that formula's cache eligibility check.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adjusts brew cleanup cache staleness checks to avoid aborting when an installed formula can’t be loaded due to tap trust restrictions, and adds test coverage for that scenario.
Changes:
- Rescue
Homebrew::UntrustedTapErrorduring cache staleness checks sobrew cleanupcan continue. - Emit a warning when an untrusted tap formula prevents determining cache eligibility.
- Add an RSpec example asserting untrusted-formula cache entries are skipped and not removed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Library/Homebrew/cleanup.rb | Skip cache staleness evaluation when loading an installed formula raises UntrustedTapError, warning instead of aborting. |
| Library/Homebrew/test/cleanup_spec.rb | Adds a regression test ensuring untrusted formula loading doesn’t remove the cache entry and warns to stderr. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Coverage OverviewLanguages: Ruby Ruby / code-coverage/simplecovThe overall coverage in the branch remains at 78%, unchanged from the branch. Show a code coverage summary of the most impacted files.
Updated |
nandahkrishna
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22551
brew cleanupwhen cache checks cannot load an installed formula from an untrusted tap.brew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex 5.5 xhigh with local review and testing.