Skip to content

generate-cask-ci-matrix: respect maximum_macos requirement#22556

Merged
MikeMcQuaid merged 1 commit into
mainfrom
cask-ci-matrix-maximum-macos
Jun 6, 2026
Merged

generate-cask-ci-matrix: respect maximum_macos requirement#22556
MikeMcQuaid merged 1 commit into
mainfrom
cask-ci-matrix-maximum-macos

Conversation

@p-linnane
Copy link
Copy Markdown
Member


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

Implemented with Claude Code, verified and tested locally.


Copilot AI review requested due to automatic review settings June 5, 2026 20:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the generate-cask-ci-matrix dev command to respect cask depends_on maximum_macos constraints when selecting GitHub Actions macOS runners, ensuring CI jobs aren’t generated for macOS versions the cask declares unsupported.

Changes:

  • Update runner filtering to apply both minimum (depends_on macos:) and maximum (depends_on maximum_macos:) macOS requirements when selecting macOS runners.
  • Add specs covering minimum macOS, maximum macOS, and the “no runners satisfy maximum” case (macOS is skipped rather than testing all macOS runners).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb Applies maximum_macos (and minimum macOS) constraints when filtering macOS CI runners.
Library/Homebrew/test/dev-cmd/generate-cask-ci-matrix_spec.rb Adds unit tests asserting runner selection respects min/max macOS requirements and skips macOS when none match.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb
Comment thread Library/Homebrew/test/dev-cmd/generate-cask-ci-matrix_spec.rb
@github-code-quality
Copy link
Copy Markdown

github-code-quality Bot commented Jun 5, 2026

Code Coverage Overview

Languages: Ruby

Ruby / code-coverage/simplecov

The overall coverage in the branch is 74%. The coverage in the branch is 78%.

Show a code coverage summary of the most impacted files.
File c6a08de b854d5f +/-
cask/info.rb 96% 0% -96%
cask/installer.rb 91% 28% -63%
cask/artifact/a...ct_uninstall.rb 89% 32% -57%
cask/audit.rb 63% 25% -38%
cask/cask_loader.rb 96% 65% -31%
bundle/extensions/flatpak.rb 37% 94% +57%
extend/os/linux/diagnostic.rb 0% 67% +67%
os/linux/elf.rb 0% 84% +84%
extend/os/linux/sandbox.rb 0% 95% +95%
extend/os/linux...ystem_config.rb 0% 99% +99%

Updated June 06, 2026 01:09 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 6, 2026
Merged via the queue into main with commit 000e674 Jun 6, 2026
57 of 58 checks passed
@MikeMcQuaid MikeMcQuaid deleted the cask-ci-matrix-maximum-macos branch June 6, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants