generate-cask-ci-matrix: respect maximum_macos requirement#22556
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the generate-cask-ci-matrix dev command to respect cask depends_on maximum_macos constraints when selecting GitHub Actions macOS runners, ensuring CI jobs aren’t generated for macOS versions the cask declares unsupported.
Changes:
- Update runner filtering to apply both minimum (
depends_on macos:) and maximum (depends_on maximum_macos:) macOS requirements when selecting macOS runners. - Add specs covering minimum macOS, maximum macOS, and the “no runners satisfy maximum” case (macOS is skipped rather than testing all macOS runners).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb | Applies maximum_macos (and minimum macOS) constraints when filtering macOS CI runners. |
| Library/Homebrew/test/dev-cmd/generate-cask-ci-matrix_spec.rb | Adds unit tests asserting runner selection respects min/max macOS requirements and skips macOS when none match. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Coverage OverviewLanguages: Ruby Ruby / code-coverage/simplecovThe overall coverage in the branch is 74%. The coverage in the branch is 78%. Show a code coverage summary of the most impacted files.
Updated |
Signed-off-by: Patrick Linnane <patrick@linnane.io>
044afa6 to
b854d5f
Compare
9 tasks
carlocab
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Implemented with Claude Code, verified and tested locally.