Skip to content

Enable more cask metadata migration to JSON for all users#22958

Merged
MikeMcQuaid merged 1 commit into
mainfrom
cask-json-caskroom-migration-all-users
Jul 13, 2026
Merged

Enable more cask metadata migration to JSON for all users#22958
MikeMcQuaid merged 1 commit into
mainfrom
cask-json-caskroom-migration-all-users

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Remove the developer gate after proving the update-time path.
  • Keep the regression pinned to a non-developer update run.

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.5 xhigh with local review and testing.


@MikeMcQuaid MikeMcQuaid changed the title Enable cask metadata migration Enable more cask metadata migration to JSON for all users Jul 5, 2026
@MikeMcQuaid MikeMcQuaid force-pushed the cask-json-caskroom-migration-all-users branch from ae4cc2c to cf1c829 Compare July 5, 2026 13:22
Base automatically changed from cask-json-caskroom-migration-developers to main July 10, 2026 08:24
- Remove the developer gate after proving the update-time path.
- Keep the regression pinned to a non-developer update run.
@MikeMcQuaid MikeMcQuaid force-pushed the cask-json-caskroom-migration-all-users branch from cf1c829 to e4e0971 Compare July 10, 2026 08:31
@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review July 10, 2026 08:32
Copilot AI review requested due to automatic review settings July 10, 2026 08:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the existing brew update “update-report” migration logic so it converts supported installed Cask metadata (legacy Ruby caskfiles and *.internal.json) into installed *.json metadata for all users, not just developers. This aligns the migration behavior with the intended broader rollout while keeping the regression coverage anchored to a non-developer update run.

Changes:

  • Remove the Homebrew::EnvConfig.developer? gate from migrate_caskroom_caskfiles_to_json, enabling migration for all users.
  • Update the existing spec to assert migration occurs when developer? is false and adjust the example description accordingly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Library/Homebrew/cmd/update-report.rb Enables cask metadata migration during update-report runs for all users by removing the developer-only guard.
Library/Homebrew/test/cmd/update-report_spec.rb Updates regression coverage to validate the migration in a non-developer environment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval by github-actions[bot] for #22958 because all requirements are met:

  • #22958 is not from a fork.
  • #22958 is not a draft.
  • The approval workflow is running on a weekday.
  • @MikeMcQuaid is listed as a lead maintainer in README.md.
  • @MikeMcQuaid approved Homebrew/brew PR #23038 in the last 7 days.
  • #22958 was created at least 48 hours ago and has had no human review since creation.
  • Copilot has already reviewed #22958.
  • #22958 does not modify .github/ or other sensitive files.
  • All CI jobs are passing, including non-required jobs.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 13, 2026
Merged via the queue into main with commit fc5075e Jul 13, 2026
42 checks passed
@MikeMcQuaid MikeMcQuaid deleted the cask-json-caskroom-migration-all-users branch July 13, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants