Enable more cask metadata migration to JSON for all users#22958
Merged
Conversation
ae4cc2c to
cf1c829
Compare
- Remove the developer gate after proving the update-time path. - Keep the regression pinned to a non-developer update run.
cf1c829 to
e4e0971
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the existing brew update “update-report” migration logic so it converts supported installed Cask metadata (legacy Ruby caskfiles and *.internal.json) into installed *.json metadata for all users, not just developers. This aligns the migration behavior with the intended broader rollout while keeping the regression coverage anchored to a non-developer update run.
Changes:
- Remove the
Homebrew::EnvConfig.developer?gate frommigrate_caskroom_caskfiles_to_json, enabling migration for all users. - Update the existing spec to assert migration occurs when
developer?isfalseand adjust the example description accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/cmd/update-report.rb | Enables cask metadata migration during update-report runs for all users by removing the developer-only guard. |
| Library/Homebrew/test/cmd/update-report_spec.rb | Updates regression coverage to validate the migration in a non-developer environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Automated approval by github-actions[bot] for #22958 because all requirements are met:
- #22958 is not from a fork.
- #22958 is not a draft.
- The approval workflow is running on a weekday.
- @MikeMcQuaid is listed as a lead maintainer in README.md.
- @MikeMcQuaid approved Homebrew/brew PR #23038 in the last 7 days.
- #22958 was created at least 48 hours ago and has had no human review since creation.
- Copilot has already reviewed #22958.
- #22958 does not modify
.github/or other sensitive files. - All CI jobs are passing, including non-required jobs.
bevanjkay
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.5 xhigh with local review and testing.